| Message ID | 20230113221058.2355840-1-andreas@kemnade.info |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ARM: dts: omap: gta04: add BNO055 IMU chip | expand |
On 13/01/2023 23:10, Andreas Kemnade wrote: > There is finally a driver upstreamed, so add the > device. > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > --- > arch/arm/boot/dts/omap3-gta04a5.dts | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm/boot/dts/omap3-gta04a5.dts b/arch/arm/boot/dts/omap3-gta04a5.dts > index 0b5bd7388877..4f56f7fc0d1b 100644 > --- a/arch/arm/boot/dts/omap3-gta04a5.dts > +++ b/arch/arm/boot/dts/omap3-gta04a5.dts > @@ -75,6 +75,11 @@ OMAP3_CORE1_IOPAD(0x2138, PIN_INPUT | MUX_MODE4) /* gpin114 */ > >; > }; > > + bno050_pins: pinmux-bno050-pins { > + pinctrl-single,pins = < > + OMAP3_CORE1_IOPAD(0x2136, PIN_INPUT | MUX_MODE4) /* gpin113 */ > + >; > + }; > }; > > /* > @@ -136,4 +141,13 @@ bme280@76 { > vdda-supply = <&vio>; > vddd-supply = <&vio>; > }; > + > + bno055@29 { Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "bosch,bno055"; > + reg = <0x29>; Best regards, Krzysztof
On Sun, 15 Jan 2023 15:58:05 +0100 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 13/01/2023 23:10, Andreas Kemnade wrote: > > There is finally a driver upstreamed, so add the > > device. > > > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > > --- > > arch/arm/boot/dts/omap3-gta04a5.dts | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/arch/arm/boot/dts/omap3-gta04a5.dts b/arch/arm/boot/dts/omap3-gta04a5.dts > > index 0b5bd7388877..4f56f7fc0d1b 100644 > > --- a/arch/arm/boot/dts/omap3-gta04a5.dts > > +++ b/arch/arm/boot/dts/omap3-gta04a5.dts > > @@ -75,6 +75,11 @@ OMAP3_CORE1_IOPAD(0x2138, PIN_INPUT | MUX_MODE4) /* gpin114 */ > > >; > > }; > > > > + bno050_pins: pinmux-bno050-pins { > > + pinctrl-single,pins = < > > + OMAP3_CORE1_IOPAD(0x2136, PIN_INPUT | MUX_MODE4) /* gpin113 */ > > + >; > > + }; > > }; > > > > /* > > @@ -136,4 +141,13 @@ bme280@76 { > > vdda-supply = <&vio>; > > vddd-supply = <&vio>; > > }; > > + > > + bno055@29 { > > Node names should be generic. > https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > the usual pitfall, just looking at the style around... Especially if it an old patch, not needing too much attention, just removing some now undefined properties. The file deserves some cleanup, since generic node names were not invented there yet. Regards, Andreas
diff --git a/arch/arm/boot/dts/omap3-gta04a5.dts b/arch/arm/boot/dts/omap3-gta04a5.dts index 0b5bd7388877..4f56f7fc0d1b 100644 --- a/arch/arm/boot/dts/omap3-gta04a5.dts +++ b/arch/arm/boot/dts/omap3-gta04a5.dts @@ -75,6 +75,11 @@ OMAP3_CORE1_IOPAD(0x2138, PIN_INPUT | MUX_MODE4) /* gpin114 */ >; }; + bno050_pins: pinmux-bno050-pins { + pinctrl-single,pins = < + OMAP3_CORE1_IOPAD(0x2136, PIN_INPUT | MUX_MODE4) /* gpin113 */ + >; + }; }; /* @@ -136,4 +141,13 @@ bme280@76 { vdda-supply = <&vio>; vddd-supply = <&vio>; }; + + bno055@29 { + compatible = "bosch,bno055"; + reg = <0x29>; + pinctrl-names = "default"; + pinctrl-0 = <&bno050_pins>; + /* interrupt at &gpio4 17 */ + }; + };
There is finally a driver upstreamed, so add the device. Signed-off-by: Andreas Kemnade <andreas@kemnade.info> --- arch/arm/boot/dts/omap3-gta04a5.dts | 14 ++++++++++++++ 1 file changed, 14 insertions(+)