[edk2,1/4] MdeModulePkg/PciHostBridgeDxe: remove unused but set variables

Message ID 1458800900-11913-2-git-send-email-ard.biesheuvel@linaro.org
State Superseded
Headers show

Commit Message

Ard Biesheuvel March 24, 2016, 6:28 a.m.
Remove variables that are declared, assigned but never referenced. This
fixes a warning emitted by GCC when -Wunused-but-set-variable is in effect.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---
 MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 8 --------
 1 file changed, 8 deletions(-)

-- 
1.9.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Laszlo Ersek March 24, 2016, 7:57 a.m. | #1
On 03/24/16 07:28, Ard Biesheuvel wrote:
> Remove variables that are declared, assigned but never referenced. This

> fixes a warning emitted by GCC when -Wunused-but-set-variable is in effect.

> 

> Contributed-under: TianoCore Contribution Agreement 1.0

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---

>  MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 8 --------

>  1 file changed, 8 deletions(-)


From those 33 patches of mine, one is identical to this one :)

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


> diff --git a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c

> index d5da6995af36..50f1407e7aea 100644

> --- a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c

> +++ b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c

> @@ -628,7 +628,6 @@ NotifyPhase (

>    PCI_ROOT_BRIDGE_INSTANCE              *RootBridge;

>    LIST_ENTRY                            *Link;

>    EFI_PHYSICAL_ADDRESS                  BaseAddress;

> -  UINT64                                AddrLen;

>    UINTN                                 BitsOfAlignment;

>    UINT64                                Alignment;

>    EFI_STATUS                            Status;

> @@ -735,7 +734,6 @@ NotifyPhase (

>  

>            ASSERT (Index < TypeMax);

>            ResNodeHandled[Index] = TRUE;

> -          AddrLen = RootBridge->ResAllocNode[Index].Length;

>            Alignment = RootBridge->ResAllocNode[Index].Alignment;

>            BitsOfAlignment = LowBitSet64 (Alignment + 1);

>            BaseAddress = MAX_UINT64;

> @@ -1110,9 +1108,6 @@ SetBusNumbers (

>    PCI_ROOT_BRIDGE_INSTANCE  *RootBridge;

>    EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *Descriptor;

>    EFI_ACPI_END_TAG_DESCRIPTOR       *End;

> -  UINTN                     BusStart;

> -  UINTN                     BusEnd;

> -  UINTN                     BusLen;

>  

>    if (Configuration == NULL) {

>      return EFI_INVALID_PARAMETER;

> @@ -1138,9 +1133,6 @@ SetBusNumbers (

>         ) {

>      RootBridge = ROOT_BRIDGE_FROM_LINK (Link);

>      if (RootBridgeHandle == RootBridge->Handle) {

> -      BusStart  = (UINTN) Descriptor->AddrRangeMin;

> -      BusLen    = (UINTN) Descriptor->AddrLen;

> -      BusEnd    = BusStart + BusLen - 1;

>  

>        if (Descriptor->AddrLen == 0) {

>          return EFI_INVALID_PARAMETER;

> 


_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c
index d5da6995af36..50f1407e7aea 100644
--- a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c
+++ b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c
@@ -628,7 +628,6 @@  NotifyPhase (
   PCI_ROOT_BRIDGE_INSTANCE              *RootBridge;
   LIST_ENTRY                            *Link;
   EFI_PHYSICAL_ADDRESS                  BaseAddress;
-  UINT64                                AddrLen;
   UINTN                                 BitsOfAlignment;
   UINT64                                Alignment;
   EFI_STATUS                            Status;
@@ -735,7 +734,6 @@  NotifyPhase (
 
           ASSERT (Index < TypeMax);
           ResNodeHandled[Index] = TRUE;
-          AddrLen = RootBridge->ResAllocNode[Index].Length;
           Alignment = RootBridge->ResAllocNode[Index].Alignment;
           BitsOfAlignment = LowBitSet64 (Alignment + 1);
           BaseAddress = MAX_UINT64;
@@ -1110,9 +1108,6 @@  SetBusNumbers (
   PCI_ROOT_BRIDGE_INSTANCE  *RootBridge;
   EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *Descriptor;
   EFI_ACPI_END_TAG_DESCRIPTOR       *End;
-  UINTN                     BusStart;
-  UINTN                     BusEnd;
-  UINTN                     BusLen;
 
   if (Configuration == NULL) {
     return EFI_INVALID_PARAMETER;
@@ -1138,9 +1133,6 @@  SetBusNumbers (
        ) {
     RootBridge = ROOT_BRIDGE_FROM_LINK (Link);
     if (RootBridgeHandle == RootBridge->Handle) {
-      BusStart  = (UINTN) Descriptor->AddrRangeMin;
-      BusLen    = (UINTN) Descriptor->AddrLen;
-      BusEnd    = BusStart + BusLen - 1;
 
       if (Descriptor->AddrLen == 0) {
         return EFI_INVALID_PARAMETER;