diff mbox series

[09/11] ARM: dts: exynos: correct SATA clocks in Exynos5250

Message ID 20230120155404.323386-10-krzysztof.kozlowski@linaro.org
State New
Headers show
Series ARM: dts: exynos: DT schema fixes | expand

Commit Message

Krzysztof Kozlowski Jan. 20, 2023, 3:54 p.m. UTC
The DT schema expects clock name matching certain patterns:

  exynos5250-smdk5250.dtb: sata@122f0000: clock-names:1: 'oneOf' conditional failed, one must be fixed:
    'sclk_sata' is not one of ['pclk', 'aclk', 'hclk', 'sata']
    'pmalive' was expected
    'rxoob' was expected
    'ref' was expected

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/exynos5250.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alim Akhtar Jan. 28, 2023, 4:42 a.m. UTC | #1
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Friday, January 20, 2023 9:24 PM
> To: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
> <alim.akhtar@samsung.com>; Inki Dae <inki.dae@samsung.com>; Kyungmin
> Park <kyungmin.park@samsung.com>; Kukjin Kim <kgene@kernel.org>;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: replicant@osuosl.org; phone-devel@vger.kernel.org;
> ~postmarketos/upstreaming@lists.sr.ht; Martin Jücker
> <martin.juecker@gmail.com>; Henrik Grimler <henrik@grimler.se>;
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Subject: [PATCH 09/11] ARM: dts: exynos: correct SATA clocks in Exynos5250
> 
> The DT schema expects clock name matching certain patterns:
> 
>   exynos5250-smdk5250.dtb: sata@122f0000: clock-names:1: 'oneOf'
> conditional failed, one must be fixed:
>     'sclk_sata' is not one of ['pclk', 'aclk', 'hclk', 'sata']
>     'pmalive' was expected
>     'rxoob' was expected
>     'ref' was expected
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>


>  arch/arm/boot/dts/exynos5250.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> index f82f82fc803f..9225f3552837 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -390,7 +390,7 @@ sata: sata@122f0000 {
>  			reg = <0x122F0000 0x1ff>;
>  			interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>;
>  			clocks = <&clock CLK_SATA>, <&clock
> CLK_SCLK_SATA>;
> -			clock-names = "sata", "sclk_sata";
> +			clock-names = "sata", "pclk";
>  			phys = <&sata_phy>;
>  			phy-names = "sata-phy";
>  			ports-implemented = <0x1>;
> --
> 2.34.1
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index f82f82fc803f..9225f3552837 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -390,7 +390,7 @@  sata: sata@122f0000 {
 			reg = <0x122F0000 0x1ff>;
 			interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&clock CLK_SATA>, <&clock CLK_SCLK_SATA>;
-			clock-names = "sata", "sclk_sata";
+			clock-names = "sata", "pclk";
 			phys = <&sata_phy>;
 			phy-names = "sata-phy";
 			ports-implemented = <0x1>;