diff mbox

[edk2,1/2] OvmfPkg: disable PcdHiiOsRuntimeSupport

Message ID 1459273890-14331-2-git-send-email-lersek@redhat.com
State Accepted
Commit eccc28bfcb91b5d72adf173d7404652c7aa63c26
Headers show

Commit Message

Laszlo Ersek March 29, 2016, 5:51 p.m. UTC 
Edk2 commit 8a45f80edad4 ("MdeModulePkg: Make HII configuration settings
available to OS runtime") implements the optional UEFI feature described
in "31.2.11.1 OS Runtime Utilization" in UEFI v2.6.

While this feature might show benefits down the road even in QEMU virtual
machines, at the moment it only presents drawbacks:
- it increases the EfiRuntimeServicesData footprint,
- it triggers HII compatibility problems between edk2 and external drivers
  unconditionally, even if the end-user is not interested in HII and/or in
  configuring said drivers (see
  <https://www.redhat.com/archives/vfio-users/2016-March/msg00153.html>
  and <http://thread.gmane.org/gmane.comp.bios.edk2.devel/9894> for an
  example).

While the feature was being introduced, popular demand for a controlling
Feature PCD rose (see
<http://thread.gmane.org/gmane.comp.bios.edk2.devel/7626>), which is why
we can set it now to FALSE.

Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>

---
 OvmfPkg/OvmfPkgIa32.dsc    | 1 +
 OvmfPkg/OvmfPkgIa32X64.dsc | 1 +
 OvmfPkg/OvmfPkgX64.dsc     | 1 +
 3 files changed, 3 insertions(+)

-- 
1.8.3.1


_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Laszlo Ersek April 6, 2016, 5:43 p.m. UTC | #1 
On 04/06/16 19:32, Jordan Justen wrote:
> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>


Commit eccc28bfcb91b5d72adf173d7404652c7aa63c26.

Thank you!
Laszlo

> 

> On 2016-03-29 10:51:29, Laszlo Ersek wrote:

>> Edk2 commit 8a45f80edad4 ("MdeModulePkg: Make HII configuration settings

>> available to OS runtime") implements the optional UEFI feature described

>> in "31.2.11.1 OS Runtime Utilization" in UEFI v2.6.

>>

>> While this feature might show benefits down the road even in QEMU virtual

>> machines, at the moment it only presents drawbacks:

>> - it increases the EfiRuntimeServicesData footprint,

>> - it triggers HII compatibility problems between edk2 and external drivers

>>   unconditionally, even if the end-user is not interested in HII and/or in

>>   configuring said drivers (see

>>   <https://www.redhat.com/archives/vfio-users/2016-March/msg00153.html>

>>   and <http://thread.gmane.org/gmane.comp.bios.edk2.devel/9894> for an

>>   example).

>>

>> While the feature was being introduced, popular demand for a controlling

>> Feature PCD rose (see

>> <http://thread.gmane.org/gmane.comp.bios.edk2.devel/7626>), which is why

>> we can set it now to FALSE.

>>

>> Cc: Jordan Justen <jordan.l.justen@intel.com>

>> Contributed-under: TianoCore Contribution Agreement 1.0

>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

>> ---

>>  OvmfPkg/OvmfPkgIa32.dsc    | 1 +

>>  OvmfPkg/OvmfPkgIa32X64.dsc | 1 +

>>  OvmfPkg/OvmfPkgX64.dsc     | 1 +

>>  3 files changed, 3 insertions(+)

>>

>> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc

>> index fd05dac19a91..96d451daffe9 100644

>> --- a/OvmfPkg/OvmfPkgIa32.dsc

>> +++ b/OvmfPkg/OvmfPkgIa32.dsc

>> @@ -361,6 +361,7 @@ [LibraryClasses.common.SMM_CORE]

>>  #

>>  ################################################################################

>>  [PcdsFeatureFlag]

>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdHiiOsRuntimeSupport|FALSE

>>    gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE

>>    gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|TRUE

>>    gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSupportUefiDecompress|FALSE

>> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc

>> index 37b429720409..69320fe25f5a 100644

>> --- a/OvmfPkg/OvmfPkgIa32X64.dsc

>> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc

>> @@ -366,6 +366,7 @@ [LibraryClasses.common.SMM_CORE]

>>  #

>>  ################################################################################

>>  [PcdsFeatureFlag]

>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdHiiOsRuntimeSupport|FALSE

>>    gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE

>>    gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|TRUE

>>    gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSupportUefiDecompress|FALSE

>> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc

>> index aeca10fdea6c..f5071ecf27fd 100644

>> --- a/OvmfPkg/OvmfPkgX64.dsc

>> +++ b/OvmfPkg/OvmfPkgX64.dsc

>> @@ -366,6 +366,7 @@ [LibraryClasses.common.SMM_CORE]

>>  #

>>  ################################################################################

>>  [PcdsFeatureFlag]

>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdHiiOsRuntimeSupport|FALSE

>>    gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE

>>    gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|TRUE

>>    gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSupportUefiDecompress|FALSE

>> -- 

>> 1.8.3.1

>>

>>

>> _______________________________________________

>> edk2-devel mailing list

>> edk2-devel@lists.01.org

>> https://lists.01.org/mailman/listinfo/edk2-devel


_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
diff mbox

Patch

diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
index fd05dac19a91..96d451daffe9 100644
--- a/OvmfPkg/OvmfPkgIa32.dsc
+++ b/OvmfPkg/OvmfPkgIa32.dsc
@@ -361,6 +361,7 @@  [LibraryClasses.common.SMM_CORE]
 #
 ################################################################################
 [PcdsFeatureFlag]
+  gEfiMdeModulePkgTokenSpaceGuid.PcdHiiOsRuntimeSupport|FALSE
   gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE
   gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|TRUE
   gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSupportUefiDecompress|FALSE
diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
index 37b429720409..69320fe25f5a 100644
--- a/OvmfPkg/OvmfPkgIa32X64.dsc
+++ b/OvmfPkg/OvmfPkgIa32X64.dsc
@@ -366,6 +366,7 @@  [LibraryClasses.common.SMM_CORE]
 #
 ################################################################################
 [PcdsFeatureFlag]
+  gEfiMdeModulePkgTokenSpaceGuid.PcdHiiOsRuntimeSupport|FALSE
   gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE
   gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|TRUE
   gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSupportUefiDecompress|FALSE
diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
index aeca10fdea6c..f5071ecf27fd 100644
--- a/OvmfPkg/OvmfPkgX64.dsc
+++ b/OvmfPkg/OvmfPkgX64.dsc
@@ -366,6 +366,7 @@  [LibraryClasses.common.SMM_CORE]
 #
 ################################################################################
 [PcdsFeatureFlag]
+  gEfiMdeModulePkgTokenSpaceGuid.PcdHiiOsRuntimeSupport|FALSE
   gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE
   gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|TRUE
   gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSupportUefiDecompress|FALSE