diff mbox

[edk2,v2] OptionRomPkg: Ax88772b: Fixing compilation

Message ID 1459315498-29044-1-git-send-email-shivamurthy.shastri@linaro.org
State Accepted
Commit 45e675f2d0eeda0511b5d6e0ed54f62f94c3826f
Headers show

Commit Message

Shivamurthy Shastri March 30, 2016, 5:24 a.m. UTC 
error: pNicDevice variable set but not used

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Shivamurthy Shastri <shivamurthy.shastri@linaro.org>

Reviewed-by: Ryan Harkin <ryan.harkin@linaro.org>

Reviewed-by: Jiaxin Wu <jiaxin.wu@intel.com>

---
 OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork.c | 2 --
 1 file changed, 2 deletions(-)

-- 
1.9.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Shivamurthy Shastri March 30, 2016, 5:27 a.m. UTC | #1 
On 30 March 2016 at 10:54, Shivamurthy Shastri <
shivamurthy.shastri@linaro.org> wrote:

> error: pNicDevice variable set but not used

>

> Contributed-under: TianoCore Contribution Agreement 1.0

> Signed-off-by: Shivamurthy Shastri <shivamurthy.shastri@linaro.org>

> Reviewed-by: Ryan Harkin <ryan.harkin@linaro.org>

> Reviewed-by: Jiaxin Wu <jiaxin.wu@intel.com>

> ---

>  OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork.c | 2 --

>  1 file changed, 2 deletions(-)

>

> diff --git a/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork.c

> b/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork.c

> index 9eeb61f..c061a6b 100644

> --- a/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork.c

> +++ b/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork.c

> @@ -700,10 +700,8 @@ SN_ReceiveFilters (

>    EFI_SIMPLE_NETWORK_MODE * pMode;

>    EFI_STATUS Status = EFI_SUCCESS;

>    EFI_TPL TplPrevious;

> -  NIC_DEVICE * pNicDevice;

>

>    TplPrevious = gBS->RaiseTPL(TPL_CALLBACK);

> -  pNicDevice = DEV_FROM_SIMPLE_NETWORK ( pSimpleNetwork );

>    pMode = pSimpleNetwork->Mode;

>

>    if (pSimpleNetwork == NULL) {

> --

> 1.9.1

>

>

Hi Ruiyu Ni,

As per your mail, I am sending patch once again.
Please review it.

Thanks,
Shiva​
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
diff mbox

Patch

diff --git a/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork.c b/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork.c
index 9eeb61f..c061a6b 100644
--- a/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork.c
+++ b/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork.c
@@ -700,10 +700,8 @@  SN_ReceiveFilters (
   EFI_SIMPLE_NETWORK_MODE * pMode;
   EFI_STATUS Status = EFI_SUCCESS;   
   EFI_TPL TplPrevious; 
-  NIC_DEVICE * pNicDevice;
 
   TplPrevious = gBS->RaiseTPL(TPL_CALLBACK);
-  pNicDevice = DEV_FROM_SIMPLE_NETWORK ( pSimpleNetwork );
   pMode = pSimpleNetwork->Mode;
 
   if (pSimpleNetwork == NULL) {