diff mbox series

[v4,2/2] Modified the schema binding and added the vendor prefixes.

Message ID 20230126020156.3252-4-kiseok.jo@irondevice.com
State Accepted
Commit dcf6d2ef0e823346a3c1eae3f96e733e92ca656c
Headers show
Series [v4,1/2] The Iron Device SMA1303 is a boosted Class-D audio amplifier. | expand

Commit Message

Kiseok Jo Jan. 26, 2023, 2:01 a.m. UTC
Signed-off-by: Kiseok Jo <kiseok.jo@irondevice.com>
---
 .../bindings/sound/irondevice,sma1303.yaml    | 32 +++++++++++++++++++
 .../devicetree/bindings/vendor-prefixes.yaml  |  2 ++
 2 files changed, 34 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml

Comments

Rob Herring Jan. 30, 2023, 2:04 p.m. UTC | #1
On Thu, Jan 26, 2023 at 02:01:56AM +0000, Kiseok Jo wrote:
> Signed-off-by: Kiseok Jo <kiseok.jo@irondevice.com>
> ---
>  .../bindings/sound/irondevice,sma1303.yaml    | 32 +++++++++++++++++++
>  .../devicetree/bindings/vendor-prefixes.yaml  |  2 ++
>  2 files changed, 34 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml

This is now in linux-next and breaking the bindings checks:

make[1]: *** Deleting file 'Documentation/devicetree/bindings/sound/irondevice,sma1303.example.dts'
Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml:28:1: found a tab character where an indentation space is expected
make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/sound/irondevice,sma1303.example.dts] Error 1
./Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml:28:1: [error] syntax error: found character '\t' that cannot start any token (syntax)
./Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml:28:1: found a tab character where an indentation space is expected
/builds/robherring/linux-dt/Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml: ignoring, error parsing file

Please send a fix. DT bindings also need to be sent to the 
devicetree@vger.kernel.org list. IOW, use get_maintainers.pl.


> diff --git a/Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml b/Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml
> new file mode 100644
> index 000000000000..eb87374cc812
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml
> @@ -0,0 +1,32 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/irondevice,sma1303.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Iron Device SMA1303 Audio Amplifier
> +
> +maintainers:
> +  - Kiseok Jo <kiseok.jo@irondevice.com>
> +
> +description:
> +  SMA1303 digital class-D audio amplifier with an integrated boost converter.
> +
> +allOf:
> +  - $ref: name-prefix.yaml#
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: true

false

> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>

Why do you need this?

> +    i2c_bus {

i2c {

> +		sma1303_amp: sma1303@1e {

Drop unused labels. Node name should be 'amplifier@1e'.

> +			compatible = "irondevice,sma1303";
> +			reg = <0x1e>;
> +		};
> +	};
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 70ffb3780621..271ff119764a 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -635,6 +635,8 @@ patternProperties:
>      description: Inverse Path
>    "^iom,.*":
>      description: Iomega Corporation
> +  "^irondevice,.*":
> +    description: Iron Device Corporation
>    "^isee,.*":
>      description: ISEE 2007 S.L.
>    "^isil,.*":
> -- 
> 2.20.1
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml b/Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml
new file mode 100644
index 000000000000..eb87374cc812
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml
@@ -0,0 +1,32 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/irondevice,sma1303.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Iron Device SMA1303 Audio Amplifier
+
+maintainers:
+  - Kiseok Jo <kiseok.jo@irondevice.com>
+
+description:
+  SMA1303 digital class-D audio amplifier with an integrated boost converter.
+
+allOf:
+  - $ref: name-prefix.yaml#
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: true
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    i2c_bus {
+		sma1303_amp: sma1303@1e {
+			compatible = "irondevice,sma1303";
+			reg = <0x1e>;
+		};
+	};
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 70ffb3780621..271ff119764a 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -635,6 +635,8 @@  patternProperties:
     description: Inverse Path
   "^iom,.*":
     description: Iomega Corporation
+  "^irondevice,.*":
+    description: Iron Device Corporation
   "^isee,.*":
     description: ISEE 2007 S.L.
   "^isil,.*":