ARM: Exynos4: Add cpu-offset property in gic device tree node

Message ID 1328021425-4233-1-git-send-email-thomas.abraham@linaro.org
State New
Headers show

Commit Message

thomas.abraham@linaro.org Jan. 31, 2012, 2:50 p.m.
Commit 'ARM: gic: allow GIC to support non-banked setups' (db0d4db22a78d31c)
requires a cpu-offset property to be specified for non-banked gic controllers,
which is the case for Exynos4.

Reported-by: Karol Lewandowski <k.lewandowski@samsung.com>
Signed-off-by: Thomas Abraham <thomas.abraham@linaro.org>
---
This patch solves the issue of boot failure with SMP enabled kernel for
Exynos4 device tree enabled machine.

 arch/arm/boot/dts/exynos4210.dtsi |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Kukjin Kim Jan. 31, 2012, 2:52 p.m. | #1
On 01/31/12 23:50, Thomas Abraham wrote:
> Commit 'ARM: gic: allow GIC to support non-banked setups' (db0d4db22a78d31c)

I think, following format is more general.
commit id ("subject")

Please see, below.
http://lkml.org/lkml/2010/6/1/498

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

> requires a cpu-offset property to be specified for non-banked gic controllers,
> which is the case for Exynos4.
>
> Reported-by: Karol Lewandowski<k.lewandowski@samsung.com>
> Signed-off-by: Thomas Abraham<thomas.abraham@linaro.org>
> ---
> This patch solves the issue of boot failure with SMP enabled kernel for
> Exynos4 device tree enabled machine.
>
>   arch/arm/boot/dts/exynos4210.dtsi |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi
> index 63d7578..a1dd2ee 100644
> --- a/arch/arm/boot/dts/exynos4210.dtsi
> +++ b/arch/arm/boot/dts/exynos4210.dtsi
> @@ -29,6 +29,7 @@
>   		compatible = "arm,cortex-a9-gic";
>   		#interrupt-cells =<3>;
>   		interrupt-controller;
> +		cpu-offset =<0x8000>;
>   		reg =<0x10490000 0x1000>,<0x10480000 0x100>;
>   	};
>
thomas.abraham@linaro.org Jan. 31, 2012, 2:54 p.m. | #2
On 31 January 2012 20:22, Kukjin Kim <kgene.kim@samsung.com> wrote:
> On 01/31/12 23:50, Thomas Abraham wrote:
>>
>> Commit 'ARM: gic: allow GIC to support non-banked setups'
>> (db0d4db22a78d31c)
>
>
> I think, following format is more general.
> commit id ("subject")
>
> Please see, below.
> http://lkml.org/lkml/2010/6/1/498

Thanks for the pointer Mr. Kim. I will resubmit with that change.

Regards,
Thomas.

>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
>
>> requires a cpu-offset property to be specified for non-banked gic
>> controllers,
>> which is the case for Exynos4.
>>
>> Reported-by: Karol Lewandowski<k.lewandowski@samsung.com>
>> Signed-off-by: Thomas Abraham<thomas.abraham@linaro.org>
>> ---
>> This patch solves the issue of boot failure with SMP enabled kernel for
>> Exynos4 device tree enabled machine.
>>
>>  arch/arm/boot/dts/exynos4210.dtsi |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos4210.dtsi
>> b/arch/arm/boot/dts/exynos4210.dtsi
>> index 63d7578..a1dd2ee 100644
>> --- a/arch/arm/boot/dts/exynos4210.dtsi
>> +++ b/arch/arm/boot/dts/exynos4210.dtsi
>> @@ -29,6 +29,7 @@
>>                compatible = "arm,cortex-a9-gic";
>>                #interrupt-cells =<3>;
>>                interrupt-controller;
>> +               cpu-offset =<0x8000>;
>>                reg =<0x10490000 0x1000>,<0x10480000 0x100>;
>>        };
>>
>

Patch

diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi
index 63d7578..a1dd2ee 100644
--- a/arch/arm/boot/dts/exynos4210.dtsi
+++ b/arch/arm/boot/dts/exynos4210.dtsi
@@ -29,6 +29,7 @@ 
 		compatible = "arm,cortex-a9-gic";
 		#interrupt-cells = <3>;
 		interrupt-controller;
+		cpu-offset = <0x8000>;
 		reg = <0x10490000 0x1000>, <0x10480000 0x100>;
 	};