[v2] ARM: Exynos4: Add cpu-offset property in gic device tree node

Message ID 1328023789-4672-1-git-send-email-thomas.abraham@linaro.org
State New
Headers show

Commit Message

thomas.abraham@linaro.org Jan. 31, 2012, 3:29 p.m.
Commit db0d4db22a78 ('ARM: gic: allow GIC to support non-banked setups)
requires a cpu-offset property to be specified for non-banked gic
controllers, which is the case for Exynos4.

Reported-by: Karol Lewandowski <k.lewandowski@samsung.com>
Signed-off-by: Thomas Abraham <thomas.abraham@linaro.org>
---
This patch solves the issue of boot failure with SMP enabled kernel for
Exynos4 device tree enabled machine.

 arch/arm/boot/dts/exynos4210.dtsi |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Karol Lewandowski Jan. 31, 2012, 4:41 p.m. | #1
On 31.01.2012 16:29, Thomas Abraham wrote:
> Commit db0d4db22a78 ('ARM: gic: allow GIC to support non-banked setups)
> requires a cpu-offset property to be specified for non-banked gic
> controllers, which is the case for Exynos4.
>
> Reported-by: Karol Lewandowski<k.lewandowski@samsung.com>

( Minor note - my email address lacks 'i' at the end, i.e. it's
   k.lewandowsk@ :)

> Signed-off-by: Thomas Abraham<thomas.abraham@linaro.org>
> ---
> This patch solves the issue of boot failure with SMP enabled kernel for
> Exynos4 device tree enabled machine.

Tested-by: Karol Lewandowski <k.lewandowsk@samsung.com>

Thanks!
Kukjin Kim Feb. 9, 2012, 10:23 a.m. | #2
Karol Lewandowski wrote:
> 
> On 31.01.2012 16:29, Thomas Abraham wrote:
> > Commit db0d4db22a78 ('ARM: gic: allow GIC to support non-banked setups)
> > requires a cpu-offset property to be specified for non-banked gic
> > controllers, which is the case for Exynos4.
> >
> > Reported-by: Karol Lewandowski<k.lewandowski@samsung.com>
> 
> ( Minor note - my email address lacks 'i' at the end, i.e. it's
>    k.lewandowsk@ :)
> 
> > Signed-off-by: Thomas Abraham<thomas.abraham@linaro.org>
> > ---
> > This patch solves the issue of boot failure with SMP enabled kernel for
> > Exynos4 device tree enabled machine.
> 
> Tested-by: Karol Lewandowski <k.lewandowsk@samsung.com>
> 
Applied with fixing Karol's e-mail address.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

Patch hide | download patch | download mbox

diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi
index 63d7578..a1dd2ee 100644
--- a/arch/arm/boot/dts/exynos4210.dtsi
+++ b/arch/arm/boot/dts/exynos4210.dtsi
@@ -29,6 +29,7 @@ 
 		compatible = "arm,cortex-a9-gic";
 		#interrupt-cells = <3>;
 		interrupt-controller;
+		cpu-offset = <0x8000>;
 		reg = <0x10490000 0x1000>, <0x10480000 0x100>;
 	};