diff mbox

[ARM] Delete ASM_OUTPUT_DEF and fall back to default .set directive

Message ID 1459438878-21244-1-git-send-email-james.greenhalgh@arm.com
State New
Headers show

Commit Message

James Greenhalgh March 31, 2016, 3:41 p.m. UTC
Hi,

gcc.dg/torture/pr69951.c has been failing for arm*-*-linux* targets, as
we put out "b = a" as a way of defining a symbol alias, which trips an
assembler warning if the left hand side is an instruction name (such as 'b'
for branch, see [1] for context).

We don't want to do this, a simple .set directive will suffice. This can
be achieved by deleting the definition of ASM_OUTPUT_DEF in
config/arm/linux-elf.h . This will cause us to fall back to the default
definition, as we have SET_ASM_OP defined through config/elfos.h for all
ARM ports. This patch makes that change.

Built and tested on an arm-none-linux-gnueabihf box with no issues.

OK?

Thanks,
James

---
2016-03-31  James Greenhalgh  <james.greenhalgh@arm.com>

	* config/arm/linux-elf.h (ASM_OUTPUT_DEF): Delete.

---

[1]: https://gcc.gnu.org/ml/gcc-patches/2016-03/msg00018.html

Comments

Ramana Radhakrishnan March 31, 2016, 3:45 p.m. UTC | #1
On 31/03/16 16:41, James Greenhalgh wrote:
> 

> Hi,

> 

> gcc.dg/torture/pr69951.c has been failing for arm*-*-linux* targets, as

> we put out "b = a" as a way of defining a symbol alias, which trips an

> assembler warning if the left hand side is an instruction name (such as 'b'

> for branch, see [1] for context).

> 

> We don't want to do this, a simple .set directive will suffice. This can

> be achieved by deleting the definition of ASM_OUTPUT_DEF in

> config/arm/linux-elf.h . This will cause us to fall back to the default

> definition, as we have SET_ASM_OP defined through config/elfos.h for all

> ARM ports. This patch makes that change.

> 

> Built and tested on an arm-none-linux-gnueabihf box with no issues.

> 

> OK?



Ok.

Ramana
> 

> Thanks,

> James

> 

> ---

> 2016-03-31  James Greenhalgh  <james.greenhalgh@arm.com>

> 

> 	* config/arm/linux-elf.h (ASM_OUTPUT_DEF): Delete.

> 

> ---

> 

> [1]: https://gcc.gnu.org/ml/gcc-patches/2016-03/msg00018.html

>
diff mbox

Patch

diff --git a/gcc/config/arm/linux-elf.h b/gcc/config/arm/linux-elf.h
index 472141d..a94bd2d 100644
--- a/gcc/config/arm/linux-elf.h
+++ b/gcc/config/arm/linux-elf.h
@@ -85,17 +85,6 @@ 
     }						\
   while (0)
 
-/* This is how we tell the assembler that two symbols have the same value.  */
-#define ASM_OUTPUT_DEF(FILE, NAME1, NAME2) \
-  do					   \
-    {					   \
-      assemble_name (FILE, NAME1); 	   \
-      fputs (" = ", FILE);		   \
-      assemble_name (FILE, NAME2);	   \
-      fputc ('\n', FILE);		   \
-    }					   \
-  while (0)
-
 #undef  FPUTYPE_DEFAULT
 #define FPUTYPE_DEFAULT "vfp"