| Message ID | 1459504031-4733-1-git-send-email-christophe.milard@linaro.org |
|---|---|
| State | Accepted |
| Commit | 14a566c57980f9700499c5c6ec7deb4d7ca33df9 |
| Headers | show |
Ping... On 1 April 2016 at 11:47, Christophe Milard <christophe.milard@linaro.org> wrote: > Fixes: https://bugs.linaro.org/show_bug.cgi?id=2147 (CID 159394) > The fifo is closed at end of test > > Signed-off-by: Christophe Milard <christophe.milard@linaro.org> > --- > since v1: bug URL added in commit msg (Anders) > > platform/linux-generic/test/shmem/shmem_odp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/platform/linux-generic/test/shmem/shmem_odp.c > b/platform/linux-generic/test/shmem/shmem_odp.c > index df1d3ff..a1f750f 100644 > --- a/platform/linux-generic/test/shmem/shmem_odp.c > +++ b/platform/linux-generic/test/shmem/shmem_odp.c > @@ -48,6 +48,7 @@ void shmem_test_odp_shm_proc(void) > CU_ASSERT_FATAL(fd >= 0); > > CU_ASSERT(read(fd, &test_result, sizeof(char)) == 1); > + close(fd); > CU_ASSERT_FATAL(test_result == TEST_SUCCESS); > > CU_ASSERT(odp_shm_free(shm) == 0); > -- > 2.1.4 > >
On 1 April 2016 at 05:47, Christophe Milard <christophe.milard@linaro.org> wrote: > Fixes: https://bugs.linaro.org/show_bug.cgi?id=2147 (CID 159394) > The fifo is closed at end of test > > Signed-off-by: Christophe Milard <christophe.milard@linaro.org> > Reviewed-by: Mike Holmes <mike.holmes@linaro.org> > --- > since v1: bug URL added in commit msg (Anders) > > platform/linux-generic/test/shmem/shmem_odp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/platform/linux-generic/test/shmem/shmem_odp.c > b/platform/linux-generic/test/shmem/shmem_odp.c > index df1d3ff..a1f750f 100644 > --- a/platform/linux-generic/test/shmem/shmem_odp.c > +++ b/platform/linux-generic/test/shmem/shmem_odp.c > @@ -48,6 +48,7 @@ void shmem_test_odp_shm_proc(void) > CU_ASSERT_FATAL(fd >= 0); > > CU_ASSERT(read(fd, &test_result, sizeof(char)) == 1); > + close(fd); > CU_ASSERT_FATAL(test_result == TEST_SUCCESS); > > CU_ASSERT(odp_shm_free(shm) == 0); > -- > 2.1.4 > > -- Mike Holmes Technical Manager - Linaro Networking Group Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs "Work should be fun and collaborative, the rest follows"
Merged, Maxim. On 04/14/16 16:34, Mike Holmes wrote: > > > On 1 April 2016 at 05:47, Christophe Milard > <christophe.milard@linaro.org <mailto:christophe.milard@linaro.org>> > wrote: > > Fixes: https://bugs.linaro.org/show_bug.cgi?id=2147 (CID 159394) > The fifo is closed at end of test > > Signed-off-by: Christophe Milard <christophe.milard@linaro.org > <mailto:christophe.milard@linaro.org>> > > > Reviewed-by: Mike Holmes <mike.holmes@linaro.org > <mailto:mike.holmes@linaro.org>> > > --- > since v1: bug URL added in commit msg (Anders) > > platform/linux-generic/test/shmem/shmem_odp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/platform/linux-generic/test/shmem/shmem_odp.c > b/platform/linux-generic/test/shmem/shmem_odp.c > index df1d3ff..a1f750f 100644 > --- a/platform/linux-generic/test/shmem/shmem_odp.c > +++ b/platform/linux-generic/test/shmem/shmem_odp.c > @@ -48,6 +48,7 @@ void shmem_test_odp_shm_proc(void) > CU_ASSERT_FATAL(fd >= 0); > > CU_ASSERT(read(fd, &test_result, sizeof(char)) == 1); > + close(fd); > CU_ASSERT_FATAL(test_result == TEST_SUCCESS); > > CU_ASSERT(odp_shm_free(shm) == 0); > -- > 2.1.4 > > > > > -- > Mike Holmes > Technical Manager - Linaro Networking Group > Linaro.org <http://www.linaro.org/>***│ *Open source software for ARM SoCs > "Work should be fun and collaborative, the rest follows" > > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp
diff --git a/platform/linux-generic/test/shmem/shmem_odp.c b/platform/linux-generic/test/shmem/shmem_odp.c index df1d3ff..a1f750f 100644 --- a/platform/linux-generic/test/shmem/shmem_odp.c +++ b/platform/linux-generic/test/shmem/shmem_odp.c @@ -48,6 +48,7 @@ void shmem_test_odp_shm_proc(void) CU_ASSERT_FATAL(fd >= 0); CU_ASSERT(read(fd, &test_result, sizeof(char)) == 1); + close(fd); CU_ASSERT_FATAL(test_result == TEST_SUCCESS); CU_ASSERT(odp_shm_free(shm) == 0);
Fixes: https://bugs.linaro.org/show_bug.cgi?id=2147 (CID 159394) The fifo is closed at end of test Signed-off-by: Christophe Milard <christophe.milard@linaro.org> --- since v1: bug URL added in commit msg (Anders) platform/linux-generic/test/shmem/shmem_odp.c | 1 + 1 file changed, 1 insertion(+)