| Message ID | 4927895.GXAFRqVoOG@tool |
|---|---|
| State | New |
| Headers | show |
| Series | power: reset: linkstation-poweroff: add LS220D/E | expand |
Hi Sebastian, El lun, 13 feb 2023 a las 22:22, Sebastian Reichel (<sebastian.reichel@collabora.com>) escribió: > > [+cc DT binding people] > > Hi, > > On Mon, Feb 13, 2023 at 09:38:24PM +0100, Daniel González Cabanelas wrote: > > > > static const struct of_device_id ls_poweroff_of_match[] = { > > > > + { .compatible = "buffalo,ls220d", > > > > + .data = &linkstation_power_off_cfg, > > > > + }, > > > > + { .compatible = "buffalo,ls220de", > > > > + .data = &linkstation_power_off_cfg, > > > > + }, > > > > { .compatible = "buffalo,ls421d", > > > > .data = &linkstation_power_off_cfg, > > > > }, > > > > > > Where is the patch adding these compatibles to the DT binding > > > documentation? > > > > There is no DT binding at all. So no documentation. > > You are referencing a compatible, so there is supposed to be > a DT binding for it. Note, that you also need DT bindings for > board level compatible values. See for example: > > Documentation/devicetree/bindings/arm/rockchip.yaml > Documentation/devicetree/bindings/arm/fsl.yaml Since the driver uses the root compatible string, I don't see any binding to document at least for the driver itself. Nor I don't see where a reference for this driver should be put if I documented the board compatible strings. > > -- Sebastian
diff --git a/drivers/power/reset/linkstation-poweroff.c b/drivers/power/reset/linkstation-poweroff.c index 02f5fdb8f..cfee2efd9 100644 --- a/drivers/power/reset/linkstation-poweroff.c +++ b/drivers/power/reset/linkstation-poweroff.c @@ -142,6 +142,12 @@ static void linkstation_poweroff(void) } static const struct of_device_id ls_poweroff_of_match[] = { + { .compatible = "buffalo,ls220d", + .data = &linkstation_power_off_cfg, + }, + { .compatible = "buffalo,ls220de", + .data = &linkstation_power_off_cfg, + }, { .compatible = "buffalo,ls421d", .data = &linkstation_power_off_cfg, },
Add 2 new devices to the compatible list: - Buffalo Linkstation LS220D - Buffalo Linkstation LS220DE Signed-off-by: Daniel González Cabanelas <dgcbueu@gmail.com> --- drivers/power/reset/linkstation-poweroff.c | 6 ++++++ 1 file changed, 6 insertions(+)