From patchwork Fri Apr 8 09:44:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 65371 Delivered-To: patch@linaro.org Received: by 10.112.43.237 with SMTP id z13csp569190lbl; Fri, 8 Apr 2016 02:45:39 -0700 (PDT) X-Received: by 10.157.42.75 with SMTP id t69mr3893298ota.73.1460108736956; Fri, 08 Apr 2016 02:45:36 -0700 (PDT) Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id 2si4351696oth.87.2016.04.08.02.45.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Apr 2016 02:45:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 10DAD1A1FB8; Fri, 8 Apr 2016 02:45:32 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received: from mail-wm0-x22c.google.com (mail-wm0-x22c.google.com [IPv6:2a00:1450:400c:c09::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B11A51A1FB8 for ; Fri, 8 Apr 2016 02:45:30 -0700 (PDT) Received: by mail-wm0-x22c.google.com with SMTP id u206so15473285wme.1 for ; Fri, 08 Apr 2016 02:45:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=V2A+G/J4Xq/aj8wzBPv/pafxr6bMwMtAyVrNiyM6JGk=; b=L5HC9FOpeaKYGYKU3d6KuZU/imKUVwROpKW42ZSE6bnc0yPZdGF474kDMiF+VvFYuK hn76iuFEmFyqXpgWpdu87hmOqvuCkrGIRkmj+g4kIHHBPN0wvF+VgxqNEouK7yS2uwRp /rQOt9wCh3q4+soVKXsG/xudntGGdsdKeGvlM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=V2A+G/J4Xq/aj8wzBPv/pafxr6bMwMtAyVrNiyM6JGk=; b=Dtn3Jx0c4dmrB8yBde6MA7HyfKe36WRue93wY5Sz+QUK27EMyu9hCBdnXzu+G23z0P oKcyS9GbKQXHVYaBTQ24qX1z8yqo2wCPLTD1Lq2dMzs7OneQQoWGD3qb3qhTRP0BxQYp D7OuKf+i/2iX3ptp5N46T22qVqarTmETmXzRdLkfAUAmxwkekl6qlDGt/xqE+0S5LZVc q73knUF2BP57gIZtSRC6EMtA8fdEvxf5MPqtIeX3zUJSZ1uY/PenDvehw6+SQ5Eo2L6t V+u+enaXdlnplKW7Ck7fY5PGEMbjlGQ46+/H/kbTwH0DgIHPsx6QlkiPzw1rMoXWBTEb 2Dpg== X-Gm-Message-State: AD7BkJLlsPt8WnZZUoEfUGSXBDQW+tNf3urLdmoUAuUWmTe1TSsszNGrd1u+I/iwPNbOiqol X-Received: by 10.194.158.226 with SMTP id wx2mr8135201wjb.91.1460108729297; Fri, 08 Apr 2016 02:45:29 -0700 (PDT) Received: from localhost.localdomain ([195.55.142.58]) by smtp.gmail.com with ESMTPSA id s10sm9710681wjp.3.2016.04.08.02.45.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 08 Apr 2016 02:45:28 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org, lersek@redhat.com Date: Fri, 8 Apr 2016 11:44:54 +0200 Message-Id: <1460108711-12122-8-git-send-email-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1460108711-12122-1-git-send-email-ard.biesheuvel@linaro.org> References: <1460108711-12122-1-git-send-email-ard.biesheuvel@linaro.org> Subject: [edk2] [PATCH v2 07/24] ArmVirtPkg/VirtFdtDxe: drop detection of PSCI method X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ard Biesheuvel MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" The detection of the PSCI method has been moved to the EfiResetSystemLib implementation, so drop the handling from VirtFdtDxe. Since no users remain of gArmVirtTokenSpaceGuid.PcdArmPsciMethod, remove that as well. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/ArmVirtPkg.dec | 8 -------- ArmVirtPkg/ArmVirtQemu.dsc | 2 -- ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 -- ArmVirtPkg/ArmVirtXen.dsc | 2 -- ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.c | 19 +------------------ ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf | 1 - 6 files changed, 1 insertion(+), 33 deletions(-) -- 2.5.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Laszlo Ersek diff --git a/ArmVirtPkg/ArmVirtPkg.dec b/ArmVirtPkg/ArmVirtPkg.dec index adbd5e319a09..73136adf62c6 100644 --- a/ArmVirtPkg/ArmVirtPkg.dec +++ b/ArmVirtPkg/ArmVirtPkg.dec @@ -60,14 +60,6 @@ [PcdsFixedAtBuild, PcdsPatchableInModule] gArmVirtTokenSpaceGuid.PcdTerminalTypeGuidBuffer|{0x65, 0x60, 0xA6, 0xDF, 0x19, 0xB4, 0xD3, 0x11, 0x9A, 0x2D, 0x00, 0x90, 0x27, 0x3F, 0xC1, 0x4D}|VOID*|0x00000007 [PcdsDynamic, PcdsFixedAtBuild] - # - # ARM PSCI function invocations can be done either through hypervisor - # calls (HVC) or secure monitor calls (SMC). - # PcdArmPsciMethod == 1 : use HVC - # PcdArmPsciMethod == 2 : use SMC - # - gArmVirtTokenSpaceGuid.PcdArmPsciMethod|0|UINT32|0x00000003 - gArmVirtTokenSpaceGuid.PcdFwCfgSelectorAddress|0x0|UINT64|0x00000004 gArmVirtTokenSpaceGuid.PcdFwCfgDataAddress|0x0|UINT64|0x00000005 gArmVirtTokenSpaceGuid.PcdFwCfgDmaAddress|0x0|UINT64|0x00000009 diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc index 03148b67761d..d0ecea4616a6 100644 --- a/ArmVirtPkg/ArmVirtQemu.dsc +++ b/ArmVirtPkg/ArmVirtQemu.dsc @@ -221,8 +221,6 @@ [PcdsDynamicDefault.common] gArmPlatformTokenSpaceGuid.PcdPciMmio32Size|0x0 gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0x0 - gArmVirtTokenSpaceGuid.PcdArmPsciMethod|0 - gArmVirtTokenSpaceGuid.PcdFwCfgSelectorAddress|0x0 gArmVirtTokenSpaceGuid.PcdFwCfgDataAddress|0x0 gArmVirtTokenSpaceGuid.PcdFwCfgDmaAddress|0x0 diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc index cf7a5aab6d12..fde5688c2102 100644 --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc @@ -206,8 +206,6 @@ [PcdsDynamicDefault.common] gArmPlatformTokenSpaceGuid.PcdPciMmio32Size|0x0 gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0x0 - gArmVirtTokenSpaceGuid.PcdArmPsciMethod|0 - gArmVirtTokenSpaceGuid.PcdFwCfgSelectorAddress|0x0 gArmVirtTokenSpaceGuid.PcdFwCfgDataAddress|0x0 gArmVirtTokenSpaceGuid.PcdFwCfgDmaAddress|0x0 diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc index 72bc4745309b..9cf51d5554ea 100644 --- a/ArmVirtPkg/ArmVirtXen.dsc +++ b/ArmVirtPkg/ArmVirtXen.dsc @@ -146,8 +146,6 @@ [PcdsDynamicDefault.common] gArmVirtTokenSpaceGuid.PcdFwCfgDataAddress|0x0 gArmVirtTokenSpaceGuid.PcdFwCfgDmaAddress|0x0 - gArmVirtTokenSpaceGuid.PcdArmPsciMethod|0 - gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|3 ################################################################################ diff --git a/ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.c b/ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.c index 0e308497e79e..4a4713cf6ad8 100644 --- a/ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.c +++ b/ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.c @@ -46,7 +46,6 @@ typedef enum { PropertyTypeVirtio, PropertyTypeUart, PropertyTypeTimer, - PropertyTypePsci, PropertyTypeFwCfg, PropertyTypePciHost, PropertyTypeXen, @@ -63,7 +62,6 @@ STATIC CONST PROPERTY CompatibleProperties[] = { { PropertyTypeUart, "arm,pl011" }, { PropertyTypeTimer, "arm,armv7-timer" }, { PropertyTypeTimer, "arm,armv8-timer" }, - { PropertyTypePsci, "arm,psci-0.2" }, { PropertyTypeFwCfg, "qemu,fw-cfg-mmio" }, { PropertyTypePciHost, "pci-host-ecam-generic" }, { PropertyTypeXen, "xen,xen" }, @@ -292,7 +290,6 @@ InitializeVirtFdtDxe ( UINT64 RegBase; CONST INTERRUPT_PROPERTY *InterruptProp; INT32 SecIntrNum, IntrNum, VirtIntrNum, HypIntrNum; - CONST CHAR8 *PsciMethod; UINT64 FwCfgSelectorAddress; UINT64 FwCfgSelectorSize; UINT64 FwCfgDataAddress; @@ -342,8 +339,7 @@ InitializeVirtFdtDxe ( // TODO use #cells root properties instead // RegProp = fdt_getprop (DeviceTreeBase, Node, "reg", &Len); - ASSERT ((RegProp != NULL) || (PropType == PropertyTypeTimer) || - (PropType == PropertyTypePsci)); + ASSERT ((RegProp != NULL) || (PropType == PropertyTypeTimer)); switch (PropType) { case PropertyTypePciHost: @@ -479,19 +475,6 @@ InitializeVirtFdtDxe ( PcdSet32 (PcdArmArchTimerHypIntrNum, HypIntrNum); break; - case PropertyTypePsci: - PsciMethod = fdt_getprop (DeviceTreeBase, Node, "method", &Len); - - if (PsciMethod && AsciiStrnCmp (PsciMethod, "hvc", 3) == 0) { - PcdSet32 (PcdArmPsciMethod, 1); - } else if (PsciMethod && AsciiStrnCmp (PsciMethod, "smc", 3) == 0) { - PcdSet32 (PcdArmPsciMethod, 2); - } else { - DEBUG ((EFI_D_ERROR, "%a: Unknown PSCI method \"%a\"\n", __FUNCTION__, - PsciMethod)); - } - break; - case PropertyTypeXen: ASSERT (Len == 16); diff --git a/ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf b/ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf index 628b14501f45..5526fd19250e 100644 --- a/ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf +++ b/ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf @@ -50,7 +50,6 @@ [Guids] gFdtHobGuid [Pcd] - gArmVirtTokenSpaceGuid.PcdArmPsciMethod gArmVirtTokenSpaceGuid.PcdFwCfgSelectorAddress gArmVirtTokenSpaceGuid.PcdFwCfgDataAddress gArmVirtTokenSpaceGuid.PcdFwCfgDmaAddress