| Message ID | 20230215192530.299263-2-alex.bennee@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | testing/next: docker, avocado, unit, | expand |
On 15/02/2023 20.25, Alex Bennée wrote: > A significant portion of our CI logs are just enumerating each > successfully built object file. The current widespread versions of > ninja don't have a quiet option so we use NINJA_STATUS to add a fixed > string to the ninja output which we then filter with grep. If there > are any errors in the output we get them from the compiler. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > .gitlab-ci.d/buildtest-template.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.gitlab-ci.d/buildtest-template.yml b/.gitlab-ci.d/buildtest-template.yml > index 73ecfabb8d..3af51846cd 100644 > --- a/.gitlab-ci.d/buildtest-template.yml > +++ b/.gitlab-ci.d/buildtest-template.yml > @@ -21,7 +21,7 @@ > then > ../meson/meson.py configure . -Dbackend_max_links="$LD_JOBS" ; > fi || exit 1; > - - make -j"$JOBS" > + - env NINJA_STATUS="[ninja][%f/%t] " make -j"$JOBS" | grep -v "\[ninja\]\[.*[123456789]/" > - if test -n "$MAKE_CHECK_ARGS"; > then > make -j"$JOBS" $MAKE_CHECK_ARGS ; Not meant as a veto, but just for the records: I still don't like the idea. Having a log of the files that got compiled is still sometimes useful for me, e.g. when I want to check whether a certain file has been compiled at all or not (when e.g. debugging meson.build problems). So I'm still in favour of dropping this patch. IMHO if you want to shorten the build log in the CI, please get those chatty softfloat tests fixed instead. Thomas
diff --git a/.gitlab-ci.d/buildtest-template.yml b/.gitlab-ci.d/buildtest-template.yml index 73ecfabb8d..3af51846cd 100644 --- a/.gitlab-ci.d/buildtest-template.yml +++ b/.gitlab-ci.d/buildtest-template.yml @@ -21,7 +21,7 @@ then ../meson/meson.py configure . -Dbackend_max_links="$LD_JOBS" ; fi || exit 1; - - make -j"$JOBS" + - env NINJA_STATUS="[ninja][%f/%t] " make -j"$JOBS" | grep -v "\[ninja\]\[.*[123456789]/" - if test -n "$MAKE_CHECK_ARGS"; then make -j"$JOBS" $MAKE_CHECK_ARGS ;
A significant portion of our CI logs are just enumerating each successfully built object file. The current widespread versions of ninja don't have a quiet option so we use NINJA_STATUS to add a fixed string to the ninja output which we then filter with grep. If there are any errors in the output we get them from the compiler. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- .gitlab-ci.d/buildtest-template.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)