diff mbox

[RFC,tip/core/rcu,06/41] rcu: Move RCU_TRACE to lib/Kconfig.debug

Message ID 1328125319-5205-6-git-send-email-paulmck@linux.vnet.ibm.com
State New
Headers show

Commit Message

Paul E. McKenney Feb. 1, 2012, 7:41 p.m. UTC 
From: "Paul E. McKenney" <paul.mckenney@linaro.org>

The RCU_TRACE kernel parameter has always been intended for debugging,
not for production use.  Formalize this by moving RCU_TRACE from
init/Kconfig to lib/Kconfig.debug.

Signed-off-by: Paul E. McKenney <paul.mckenney@linaro.org>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
---
 init/Kconfig      |    9 ---------
 lib/Kconfig.debug |    9 +++++++++
 2 files changed, 9 insertions(+), 9 deletions(-)

Comments

Josh Triplett Feb. 2, 2012, 1:39 a.m. UTC | #1 
On Wed, Feb 01, 2012 at 11:41:24AM -0800, Paul E. McKenney wrote:
> The RCU_TRACE kernel parameter has always been intended for debugging,
> not for production use.  Formalize this by moving RCU_TRACE from
> init/Kconfig to lib/Kconfig.debug.

Shouldn't it then depend on DEBUG_KERNEL?

- Josh Triplett
Paul E. McKenney Feb. 2, 2012, 5:05 p.m. UTC | #2 
On Wed, Feb 01, 2012 at 05:39:52PM -0800, Josh Triplett wrote:
> On Wed, Feb 01, 2012 at 11:41:24AM -0800, Paul E. McKenney wrote:
> > The RCU_TRACE kernel parameter has always been intended for debugging,
> > not for production use.  Formalize this by moving RCU_TRACE from
> > init/Kconfig to lib/Kconfig.debug.
> 
> Shouldn't it then depend on DEBUG_KERNEL?

Good point, done!

							Thanx, Paul
diff mbox

Patch

diff --git a/init/Kconfig b/init/Kconfig
index 3f42cd6..72f33fa 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -438,15 +438,6 @@  config PREEMPT_RCU
 	  This option enables preemptible-RCU code that is common between
 	  the TREE_PREEMPT_RCU and TINY_PREEMPT_RCU implementations.
 
-config RCU_TRACE
-	bool "Enable tracing for RCU"
-	help
-	  This option provides tracing in RCU which presents stats
-	  in debugfs for debugging RCU implementation.
-
-	  Say Y here if you want to enable RCU tracing
-	  Say N if you are unsure.
-
 config RCU_FANOUT
 	int "Tree-based hierarchical RCU fanout value"
 	range 2 64 if 64BIT
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 8745ac7..bb67ce2 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -927,6 +927,15 @@  config RCU_CPU_STALL_VERBOSE
 
 	  Say Y if you want to enable such checks.
 
+config RCU_TRACE
+	bool "Enable tracing for RCU"
+	help
+	  This option provides tracing in RCU which presents stats
+	  in debugfs for debugging RCU implementation.
+
+	  Say Y here if you want to enable RCU tracing
+	  Say N if you are unsure.
+
 config KPROBES_SANITY_TEST
 	bool "Kprobes sanity tests"
 	depends on DEBUG_KERNEL