diff mbox

lxc: explicitly error on interface type=ethernet

Message ID 27449ba7331edd63526f7e9bb19126adf8dcb739.1460386617.git.crobinso@redhat.com
State Accepted
Commit 27f2b74782e15c528079c8a93e5ccf216fe7b22c
Headers show

Commit Message

Cole Robinson April 11, 2016, 2:56 p.m. UTC
It isn't implemented and does not work:

error: internal error: guest failed to start: /usr/lib/libvirt/libvirt_lxc: option '--veth' requires an argument
syntax: /usr/lib/libvirt/libvirt_lxc [OPTIONS] ...

We previously threw an explicit error, but this changed in
22cff52a2b8e06c913b1f97767e5d390fb17fc3b , which I suspect was
untested for LXC
---
 src/lxc/lxc_process.c | 2 --
 1 file changed, 2 deletions(-)

-- 
2.7.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Comments

Cole Robinson April 19, 2016, 3:41 p.m. UTC | #1
ping

On 04/11/2016 10:56 AM, Cole Robinson wrote:
> It isn't implemented and does not work:

> 

> error: internal error: guest failed to start: /usr/lib/libvirt/libvirt_lxc: option '--veth' requires an argument

> syntax: /usr/lib/libvirt/libvirt_lxc [OPTIONS] ...

> 

> We previously threw an explicit error, but this changed in

> 22cff52a2b8e06c913b1f97767e5d390fb17fc3b , which I suspect was

> untested for LXC

> ---

>  src/lxc/lxc_process.c | 2 --

>  1 file changed, 2 deletions(-)

> 

> diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c

> index 5e0bbe2..0044ee5 100644

> --- a/src/lxc/lxc_process.c

> +++ b/src/lxc/lxc_process.c

> @@ -559,8 +559,6 @@ static int virLXCProcessSetupInterfaces(virConnectPtr conn,

>              break;

>  

>          case VIR_DOMAIN_NET_TYPE_ETHERNET:

> -            break;

> -

>          case VIR_DOMAIN_NET_TYPE_USER:

>          case VIR_DOMAIN_NET_TYPE_VHOSTUSER:

>          case VIR_DOMAIN_NET_TYPE_SERVER:

> 


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Cole Robinson April 21, 2016, 1:23 p.m. UTC | #2
On 04/21/2016 05:23 AM, sonia verma wrote:
> Hi Team

> 

> Is there any breakthrough on this ?.


If what you're asking is if there's been any progress on make type=ethernet
work for LXC, the answer is no. Nobody is looking at it that I know of. If
you're interested in getting it working your best bet is to try implementing
it yourself

- Cole

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
diff mbox

Patch

diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c
index 5e0bbe2..0044ee5 100644
--- a/src/lxc/lxc_process.c
+++ b/src/lxc/lxc_process.c
@@ -559,8 +559,6 @@  static int virLXCProcessSetupInterfaces(virConnectPtr conn,
             break;
 
         case VIR_DOMAIN_NET_TYPE_ETHERNET:
-            break;
-
         case VIR_DOMAIN_NET_TYPE_USER:
         case VIR_DOMAIN_NET_TYPE_VHOSTUSER:
         case VIR_DOMAIN_NET_TYPE_SERVER: