[edk2,v3,4/9] ArmVirtPkg: get rid of A PRIORI DXE declarations for VirtFdtDxe

Message ID 1460534539-2169-5-git-send-email-ard.biesheuvel@linaro.org
State Superseded
Headers show

Commit Message

Ard Biesheuvel April 13, 2016, 8:02 a.m.
We no longer care when VirtFdtDxe executes, since the dependencies are now
all resolved via protocols. So drop the A PRIORI declaration.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---
 ArmVirtPkg/ArmVirtQemu.fdf       | 4 ----
 ArmVirtPkg/ArmVirtQemuKernel.fdf | 4 ----
 ArmVirtPkg/ArmVirtXen.fdf        | 4 ----
 3 files changed, 12 deletions(-)

-- 
2.5.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Laszlo Ersek April 13, 2016, 12:34 p.m. | #1
On 04/13/16 10:02, Ard Biesheuvel wrote:
> We no longer care when VirtFdtDxe executes, since the dependencies are now

> all resolved via protocols. So drop the A PRIORI declaration.

> 

> Contributed-under: TianoCore Contribution Agreement 1.0

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---

>  ArmVirtPkg/ArmVirtQemu.fdf       | 4 ----

>  ArmVirtPkg/ArmVirtQemuKernel.fdf | 4 ----

>  ArmVirtPkg/ArmVirtXen.fdf        | 4 ----

>  3 files changed, 12 deletions(-)


I'd prefer a more precise commit message. How about appending:

- the driver sets no dynamic PCDs any longer, and

- the only remaining functionality centers on VirtioMmioInstallDevice()
  and XenIoMmioInstall() function calls.

> 

> diff --git a/ArmVirtPkg/ArmVirtQemu.fdf b/ArmVirtPkg/ArmVirtQemu.fdf

> index b532833dd962..a7204898f473 100644

> --- a/ArmVirtPkg/ArmVirtQemu.fdf

> +++ b/ArmVirtPkg/ArmVirtQemu.fdf

> @@ -101,10 +101,6 @@ [FV.FvMain]

>  READ_LOCK_CAP      = TRUE

>  READ_LOCK_STATUS   = TRUE

>  

> -  APRIORI DXE {

> -    INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf

> -    INF ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf

> -  }

>    INF MdeModulePkg/Core/Dxe/DxeMain.inf

>    INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf

>    INF ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf

> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.fdf b/ArmVirtPkg/ArmVirtQemuKernel.fdf

> index 19e654971902..b8f66d2f472c 100644

> --- a/ArmVirtPkg/ArmVirtQemuKernel.fdf

> +++ b/ArmVirtPkg/ArmVirtQemuKernel.fdf

> @@ -123,10 +123,6 @@ [FV.FvMain]

>  READ_LOCK_CAP      = TRUE

>  READ_LOCK_STATUS   = TRUE

>  

> -  APRIORI DXE {

> -    INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf

> -    INF ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf

> -  }

>    INF MdeModulePkg/Core/Dxe/DxeMain.inf

>    INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf

>    INF ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf

> diff --git a/ArmVirtPkg/ArmVirtXen.fdf b/ArmVirtPkg/ArmVirtXen.fdf

> index 2aab7d1c3f05..56182e719e06 100644

> --- a/ArmVirtPkg/ArmVirtXen.fdf

> +++ b/ArmVirtPkg/ArmVirtXen.fdf

> @@ -123,10 +123,6 @@ [FV.FvMain]

>  READ_LOCK_CAP      = TRUE

>  READ_LOCK_STATUS   = TRUE

>  

> -  APRIORI DXE {

> -    INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf

> -    INF ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf

> -  }

>    INF MdeModulePkg/Core/Dxe/DxeMain.inf

>    INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf

>    INF ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf

> 


With the commit message extended:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Laszlo Ersek April 13, 2016, 12:46 p.m. | #2
On 04/13/16 14:34, Laszlo Ersek wrote:
> On 04/13/16 10:02, Ard Biesheuvel wrote:

>> We no longer care when VirtFdtDxe executes, since the dependencies are now

>> all resolved via protocols. So drop the A PRIORI declaration.

>>

>> Contributed-under: TianoCore Contribution Agreement 1.0

>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

>> ---

>>  ArmVirtPkg/ArmVirtQemu.fdf       | 4 ----

>>  ArmVirtPkg/ArmVirtQemuKernel.fdf | 4 ----

>>  ArmVirtPkg/ArmVirtXen.fdf        | 4 ----

>>  3 files changed, 12 deletions(-)

> 

> I'd prefer a more precise commit message. How about appending:

> 

> - the driver sets no dynamic PCDs any longer, and

> 

> - the only remaining functionality centers on VirtioMmioInstallDevice()

>   and XenIoMmioInstall() function calls.


... plus the config table installation, sorry.

Laszlo

>>

>> diff --git a/ArmVirtPkg/ArmVirtQemu.fdf b/ArmVirtPkg/ArmVirtQemu.fdf

>> index b532833dd962..a7204898f473 100644

>> --- a/ArmVirtPkg/ArmVirtQemu.fdf

>> +++ b/ArmVirtPkg/ArmVirtQemu.fdf

>> @@ -101,10 +101,6 @@ [FV.FvMain]

>>  READ_LOCK_CAP      = TRUE

>>  READ_LOCK_STATUS   = TRUE

>>  

>> -  APRIORI DXE {

>> -    INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf

>> -    INF ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf

>> -  }

>>    INF MdeModulePkg/Core/Dxe/DxeMain.inf

>>    INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf

>>    INF ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf

>> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.fdf b/ArmVirtPkg/ArmVirtQemuKernel.fdf

>> index 19e654971902..b8f66d2f472c 100644

>> --- a/ArmVirtPkg/ArmVirtQemuKernel.fdf

>> +++ b/ArmVirtPkg/ArmVirtQemuKernel.fdf

>> @@ -123,10 +123,6 @@ [FV.FvMain]

>>  READ_LOCK_CAP      = TRUE

>>  READ_LOCK_STATUS   = TRUE

>>  

>> -  APRIORI DXE {

>> -    INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf

>> -    INF ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf

>> -  }

>>    INF MdeModulePkg/Core/Dxe/DxeMain.inf

>>    INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf

>>    INF ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf

>> diff --git a/ArmVirtPkg/ArmVirtXen.fdf b/ArmVirtPkg/ArmVirtXen.fdf

>> index 2aab7d1c3f05..56182e719e06 100644

>> --- a/ArmVirtPkg/ArmVirtXen.fdf

>> +++ b/ArmVirtPkg/ArmVirtXen.fdf

>> @@ -123,10 +123,6 @@ [FV.FvMain]

>>  READ_LOCK_CAP      = TRUE

>>  READ_LOCK_STATUS   = TRUE

>>  

>> -  APRIORI DXE {

>> -    INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf

>> -    INF ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf

>> -  }

>>    INF MdeModulePkg/Core/Dxe/DxeMain.inf

>>    INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf

>>    INF ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf

>>

> 

> With the commit message extended:

> 

> Reviewed-by: Laszlo Ersek <lersek@redhat.com>

> _______________________________________________

> edk2-devel mailing list

> edk2-devel@lists.01.org

> https://lists.01.org/mailman/listinfo/edk2-devel

> 


_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ard Biesheuvel April 13, 2016, 1:18 p.m. | #3
On 13 April 2016 at 14:34, Laszlo Ersek <lersek@redhat.com> wrote:
> On 04/13/16 10:02, Ard Biesheuvel wrote:

>> We no longer care when VirtFdtDxe executes, since the dependencies are now

>> all resolved via protocols. So drop the A PRIORI declaration.

>>

>> Contributed-under: TianoCore Contribution Agreement 1.0

>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

>> ---

>>  ArmVirtPkg/ArmVirtQemu.fdf       | 4 ----

>>  ArmVirtPkg/ArmVirtQemuKernel.fdf | 4 ----

>>  ArmVirtPkg/ArmVirtXen.fdf        | 4 ----

>>  3 files changed, 12 deletions(-)

>

> I'd prefer a more precise commit message. How about appending:

>

> - the driver sets no dynamic PCDs any longer, and

>

> - the only remaining functionality centers on VirtioMmioInstallDevice()

>   and XenIoMmioInstall() function calls.

>


OK

>>

>> diff --git a/ArmVirtPkg/ArmVirtQemu.fdf b/ArmVirtPkg/ArmVirtQemu.fdf

>> index b532833dd962..a7204898f473 100644

>> --- a/ArmVirtPkg/ArmVirtQemu.fdf

>> +++ b/ArmVirtPkg/ArmVirtQemu.fdf

>> @@ -101,10 +101,6 @@ [FV.FvMain]

>>  READ_LOCK_CAP      = TRUE

>>  READ_LOCK_STATUS   = TRUE

>>

>> -  APRIORI DXE {

>> -    INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf

>> -    INF ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf

>> -  }

>>    INF MdeModulePkg/Core/Dxe/DxeMain.inf

>>    INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf

>>    INF ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf

>> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.fdf b/ArmVirtPkg/ArmVirtQemuKernel.fdf

>> index 19e654971902..b8f66d2f472c 100644

>> --- a/ArmVirtPkg/ArmVirtQemuKernel.fdf

>> +++ b/ArmVirtPkg/ArmVirtQemuKernel.fdf

>> @@ -123,10 +123,6 @@ [FV.FvMain]

>>  READ_LOCK_CAP      = TRUE

>>  READ_LOCK_STATUS   = TRUE

>>

>> -  APRIORI DXE {

>> -    INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf

>> -    INF ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf

>> -  }

>>    INF MdeModulePkg/Core/Dxe/DxeMain.inf

>>    INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf

>>    INF ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf

>> diff --git a/ArmVirtPkg/ArmVirtXen.fdf b/ArmVirtPkg/ArmVirtXen.fdf

>> index 2aab7d1c3f05..56182e719e06 100644

>> --- a/ArmVirtPkg/ArmVirtXen.fdf

>> +++ b/ArmVirtPkg/ArmVirtXen.fdf

>> @@ -123,10 +123,6 @@ [FV.FvMain]

>>  READ_LOCK_CAP      = TRUE

>>  READ_LOCK_STATUS   = TRUE

>>

>> -  APRIORI DXE {

>> -    INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf

>> -    INF ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf

>> -  }

>>    INF MdeModulePkg/Core/Dxe/DxeMain.inf

>>    INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf

>>    INF ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf

>>

>

> With the commit message extended:

>

> Reviewed-by: Laszlo Ersek <lersek@redhat.com>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/ArmVirtPkg/ArmVirtQemu.fdf b/ArmVirtPkg/ArmVirtQemu.fdf
index b532833dd962..a7204898f473 100644
--- a/ArmVirtPkg/ArmVirtQemu.fdf
+++ b/ArmVirtPkg/ArmVirtQemu.fdf
@@ -101,10 +101,6 @@  [FV.FvMain]
 READ_LOCK_CAP      = TRUE
 READ_LOCK_STATUS   = TRUE
 
-  APRIORI DXE {
-    INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf
-    INF ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf
-  }
   INF MdeModulePkg/Core/Dxe/DxeMain.inf
   INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf
   INF ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf
diff --git a/ArmVirtPkg/ArmVirtQemuKernel.fdf b/ArmVirtPkg/ArmVirtQemuKernel.fdf
index 19e654971902..b8f66d2f472c 100644
--- a/ArmVirtPkg/ArmVirtQemuKernel.fdf
+++ b/ArmVirtPkg/ArmVirtQemuKernel.fdf
@@ -123,10 +123,6 @@  [FV.FvMain]
 READ_LOCK_CAP      = TRUE
 READ_LOCK_STATUS   = TRUE
 
-  APRIORI DXE {
-    INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf
-    INF ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf
-  }
   INF MdeModulePkg/Core/Dxe/DxeMain.inf
   INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf
   INF ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf
diff --git a/ArmVirtPkg/ArmVirtXen.fdf b/ArmVirtPkg/ArmVirtXen.fdf
index 2aab7d1c3f05..56182e719e06 100644
--- a/ArmVirtPkg/ArmVirtXen.fdf
+++ b/ArmVirtPkg/ArmVirtXen.fdf
@@ -123,10 +123,6 @@  [FV.FvMain]
 READ_LOCK_CAP      = TRUE
 READ_LOCK_STATUS   = TRUE
 
-  APRIORI DXE {
-    INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf
-    INF ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf
-  }
   INF MdeModulePkg/Core/Dxe/DxeMain.inf
   INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf
   INF ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf