[edk2,v3,7/9] OvmfPkg/XenIoMmioLib: add missing MemoryAllocationLib dependency to INF

Message ID 1460534539-2169-8-git-send-email-ard.biesheuvel@linaro.org
State Superseded
Headers show

Commit Message

Ard Biesheuvel April 13, 2016, 8:02 a.m.
XenIoMmioLib depends on MemoryAllocationLib, and uses its header, but
failed to declare the dependency in its INF.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---
 OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.inf | 1 +
 1 file changed, 1 insertion(+)

-- 
2.5.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Laszlo Ersek April 13, 2016, 1:01 p.m. | #1
On 04/13/16 10:02, Ard Biesheuvel wrote:
> XenIoMmioLib depends on MemoryAllocationLib, and uses its header, but

> failed to declare the dependency in its INF.

> 

> Contributed-under: TianoCore Contribution Agreement 1.0

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---

>  OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.inf | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.inf b/OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.inf

> index 16cc4530355e..d02588f281d2 100644

> --- a/OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.inf

> +++ b/OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.inf

> @@ -30,6 +30,7 @@ [Packages]

>  

>  [LibraryClasses]

>    BaseMemoryLib

> +  MemoryAllocationLib

>  

>  [Guids]

>    gXenBusRootDeviceGuid

> 


Right, it calls AllocateZeroPool() and AllocateCopyPool(), just to name two.

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


Thanks!
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.inf b/OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.inf
index 16cc4530355e..d02588f281d2 100644
--- a/OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.inf
+++ b/OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.inf
@@ -30,6 +30,7 @@  [Packages]
 
 [LibraryClasses]
   BaseMemoryLib
+  MemoryAllocationLib
 
 [Guids]
   gXenBusRootDeviceGuid