gpio: mxc: use dynamic allocation of base

Since commit 502df79b860563d7 ("gpiolib: Warn on drivers still using static
gpiobase allocation"), one or more warnings are printed during boot on
systems where static allocation of GPIO base is used:

[    1.611480] gpio gpiochip0: Static allocation of GPIO base is deprecated, use dynamic allocation.
[    1.622893] gpio gpiochip1: Static allocation of GPIO base is deprecated, use dynamic allocation.
[    1.633272] gpio gpiochip2: Static allocation of GPIO base is deprecated, use dynamic allocation.
[    1.643388] gpio gpiochip3: Static allocation of GPIO base is deprecated, use dynamic allocation.
[    1.653474] gpio gpiochip4: Static allocation of GPIO base is deprecated, use dynamic allocation.

So let's follow the suggestion and use dynamic allocation.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---

 drivers/gpio/gpio-mxc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

On Sun, Feb 26, 2023 at 9:53 PM Dario Binacchi
<dario.binacchi@amarulasolutions.com> wrote:
>
> Since commit 502df79b860563d7 ("gpiolib: Warn on drivers still using static
> gpiobase allocation"), one or more warnings are printed during boot on
> systems where static allocation of GPIO base is used:
>
> [    1.611480] gpio gpiochip0: Static allocation of GPIO base is deprecated, use dynamic allocation.
> [    1.622893] gpio gpiochip1: Static allocation of GPIO base is deprecated, use dynamic allocation.
> [    1.633272] gpio gpiochip2: Static allocation of GPIO base is deprecated, use dynamic allocation.
> [    1.643388] gpio gpiochip3: Static allocation of GPIO base is deprecated, use dynamic allocation.
> [    1.653474] gpio gpiochip4: Static allocation of GPIO base is deprecated, use dynamic allocation.
>
> So let's follow the suggestion and use dynamic allocation.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
>
>  drivers/gpio/gpio-mxc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
> index 9d0cec4b82a3..abc129a88a62 100644
> --- a/drivers/gpio/gpio-mxc.c
> +++ b/drivers/gpio/gpio-mxc.c
> @@ -462,8 +462,7 @@ static int mxc_gpio_probe(struct platform_device *pdev)
>         port->gc.request = gpiochip_generic_request;
>         port->gc.free = gpiochip_generic_free;
>         port->gc.to_irq = mxc_gpio_to_irq;
> -       port->gc.base = (pdev->id < 0) ? of_alias_get_id(np, "gpio") * 32 :
> -                                            pdev->id * 32;
> +       port->gc.base = -1;
>
>         err = devm_gpiochip_add_data(&pdev->dev, &port->gc, port);
>         if (err)
> --
> 2.32.0
>

Linus,

I'm afraid we'll need to do something about this warning, because
we're getting the same patch for like 4th time already...

Bart

On Mon, Mar 6, 2023 at 11:03 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> On Sun, Feb 26, 2023 at 9:53 PM Dario Binacchi
> <dario.binacchi@amarulasolutions.com> wrote:
> >
> > Since commit 502df79b860563d7 ("gpiolib: Warn on drivers still using static
> > gpiobase allocation"), one or more warnings are printed during boot on
> > systems where static allocation of GPIO base is used:
> >
> > [    1.611480] gpio gpiochip0: Static allocation of GPIO base is deprecated, use dynamic allocation.
> > [    1.622893] gpio gpiochip1: Static allocation of GPIO base is deprecated, use dynamic allocation.
> > [    1.633272] gpio gpiochip2: Static allocation of GPIO base is deprecated, use dynamic allocation.
> > [    1.643388] gpio gpiochip3: Static allocation of GPIO base is deprecated, use dynamic allocation.
> > [    1.653474] gpio gpiochip4: Static allocation of GPIO base is deprecated, use dynamic allocation.
(...)
> Linus,
>
> I'm afraid we'll need to do something about this warning, because
> we're getting the same patch for like 4th time already...

OK what about reverting
commit 502df79b860563d79143be7a1453c2b3224cd836
"gpiolib: Warn on drivers still using static gpiobase allocation"

Until we have less drivers with static allocations?

In a way it is good that it is fixed, but it's not good if you get
snowed under by patches and discussions about this.

Yours,
Linus Walleij

Le 07/03/2023 à 00:07, Linus Walleij a écrit :
> On Mon, Mar 6, 2023 at 11:03 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>> On Sun, Feb 26, 2023 at 9:53 PM Dario Binacchi
>> <dario.binacchi@amarulasolutions.com> wrote:
>>>
>>> Since commit 502df79b860563d7 ("gpiolib: Warn on drivers still using static
>>> gpiobase allocation"), one or more warnings are printed during boot on
>>> systems where static allocation of GPIO base is used:
>>>
>>> [    1.611480] gpio gpiochip0: Static allocation of GPIO base is deprecated, use dynamic allocation.
>>> [    1.622893] gpio gpiochip1: Static allocation of GPIO base is deprecated, use dynamic allocation.
>>> [    1.633272] gpio gpiochip2: Static allocation of GPIO base is deprecated, use dynamic allocation.
>>> [    1.643388] gpio gpiochip3: Static allocation of GPIO base is deprecated, use dynamic allocation.
>>> [    1.653474] gpio gpiochip4: Static allocation of GPIO base is deprecated, use dynamic allocation.
> (...)
>> Linus,
>>
>> I'm afraid we'll need to do something about this warning, because
>> we're getting the same patch for like 4th time already...
> 
> OK what about reverting
> commit 502df79b860563d79143be7a1453c2b3224cd836
> "gpiolib: Warn on drivers still using static gpiobase allocation"
> 
> Until we have less drivers with static allocations?
> 
> In a way it is good that it is fixed, but it's not good if you get
> snowed under by patches and discussions about this.
> 

Well, I have no strong opinion about that, as far as I remember that's 
more discussion with Arnd that made me think it was the way to go.

The Documentation has been saying since 2015 that the sysfs ABI is 
obsoleted and will be removed after 2020. So are static allocations 
required at all still ?

By the way, there are several other places in the kernel that have had 
such warnings for years without making any problem, at least that 
reminds people that something needs to be done.

Christophe