| Message ID | 1460560051-25820-1-git-send-email-ard.biesheuvel@linaro.org |
|---|---|
| State | Accepted |
| Commit | 7fba5299eb5f81096d11a7932013b0ae0e9bc0c9 |
| Headers | show |
On 13 April 2016 at 17:07, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: > This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no > longer have to rely on VirtFdtDxe to execute first and set the PL031 base > address in a dynamic PCD. > > The only driver which [transitively] depends on this PcdPL031RtcBase PCD is > EmbeddedPkg/RealTimeClockRuntimeDxe, so this conversion cannot affect any > other users and is thus safe. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > --- > > Laszlo, > > I did 'fix' it in v4, but poorly ... > ... or perhaps I didn't. Anyway, I managed to confuse myself thoroughly here, but in the end we both know what is wrong with the patch, so I will slap your R-b on the version below and push it out. Thanks for bearing with me here, Ard. > ArmVirtPkg/ArmVirtQemu.dsc | 5 ++++- > ArmVirtPkg/ArmVirtQemuKernel.dsc | 5 ++++- > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc > index c42092f54163..70419ff3f856 100644 > --- a/ArmVirtPkg/ArmVirtQemu.dsc > +++ b/ArmVirtPkg/ArmVirtQemu.dsc > @@ -293,7 +293,10 @@ [Components.common] > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf > MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf > EmbeddedPkg/ResetRuntimeDxe/ResetRuntimeDxe.inf > - EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf > + EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf { > + <LibraryClasses> > + NULL|ArmVirtPkg/Library/ArmVirtPL031FdtClientLib/ArmVirtPL031FdtClientLib.inf > + } > EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf > > MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf > diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc > index 2cbeced695f9..01029e38db3b 100644 > --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc > +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc > @@ -271,7 +271,10 @@ [Components.common] > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf > MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf > EmbeddedPkg/ResetRuntimeDxe/ResetRuntimeDxe.inf > - EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf > + EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf { > + <LibraryClasses> > + NULL|ArmVirtPkg/Library/ArmVirtPL031FdtClientLib/ArmVirtPL031FdtClientLib.inf > + } > EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf > > MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf > -- > 2.5.0 > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On 04/13/16 17:07, Ard Biesheuvel wrote: > This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no > longer have to rely on VirtFdtDxe to execute first and set the PL031 base > address in a dynamic PCD. > > The only driver which [transitively] depends on this PcdPL031RtcBase PCD is > EmbeddedPkg/RealTimeClockRuntimeDxe, so this conversion cannot affect any > other users and is thus safe. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > --- > > Laszlo, > > I did 'fix' it in v4, but poorly ... > > You may have noticed that I am getting a bit impatient. Yes. > However, please > don't mistake that for lack of respect. I highly value your review feedback, > and have no complaints whatsoever about timeliness. I do hope that you don't have complaints about my response time, given that I've been spending the overwhelming majority of my time, since you posted v1 of this series, on reviewing your work. Frequently I've spent 50 minutes or more pondering the plugin lib stuff, trying to verify if things are safe, and writing up my thoughts. > I just need a couple > more hours in a day ... Don't we all. > ArmVirtPkg/ArmVirtQemu.dsc | 5 ++++- > ArmVirtPkg/ArmVirtQemuKernel.dsc | 5 ++++- > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc > index c42092f54163..70419ff3f856 100644 > --- a/ArmVirtPkg/ArmVirtQemu.dsc > +++ b/ArmVirtPkg/ArmVirtQemu.dsc > @@ -293,7 +293,10 @@ [Components.common] > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf > MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf > EmbeddedPkg/ResetRuntimeDxe/ResetRuntimeDxe.inf > - EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf > + EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf { > + <LibraryClasses> > + NULL|ArmVirtPkg/Library/ArmVirtPL031FdtClientLib/ArmVirtPL031FdtClientLib.inf > + } > EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf > > MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf > diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc > index 2cbeced695f9..01029e38db3b 100644 > --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc > +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc > @@ -271,7 +271,10 @@ [Components.common] > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf > MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf > EmbeddedPkg/ResetRuntimeDxe/ResetRuntimeDxe.inf > - EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf > + EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf { > + <LibraryClasses> > + NULL|ArmVirtPkg/Library/ArmVirtPL031FdtClientLib/ArmVirtPL031FdtClientLib.inf > + } > EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf > > MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf > Reviewed-by: Laszlo Ersek <lersek@redhat.com> _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On 04/13/16 17:13, Ard Biesheuvel wrote: > On 13 April 2016 at 17:07, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: >> This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no >> longer have to rely on VirtFdtDxe to execute first and set the PL031 base >> address in a dynamic PCD. >> >> The only driver which [transitively] depends on this PcdPL031RtcBase PCD is >> EmbeddedPkg/RealTimeClockRuntimeDxe, so this conversion cannot affect any >> other users and is thus safe. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> >> --- >> >> Laszlo, >> >> I did 'fix' it in v4, but poorly ... >> > > ... or perhaps I didn't. Anyway, I managed to confuse myself > thoroughly here, but in the end we both know what is wrong with the > patch, so I will slap your R-b on the version below and push it out. > > Thanks for bearing with me here, Sure, no problem. I think that your refactoring is very valuable; it is definitely an improvement that VIrtFdtDxe is no longer responsible for every little thing that is described in the DT. It's just that -- I think! -- you didn't expect this rabbit hole to go this deep, while I did. (Not sure why I expected it, but I did -- I think I've struggled quite a lot with PCDs and NULL libs and ordering in OvmfPkg.) I agree you should push the series. Thanks! Laszlo > >> ArmVirtPkg/ArmVirtQemu.dsc | 5 ++++- >> ArmVirtPkg/ArmVirtQemuKernel.dsc | 5 ++++- >> 2 files changed, 8 insertions(+), 2 deletions(-) >> >> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc >> index c42092f54163..70419ff3f856 100644 >> --- a/ArmVirtPkg/ArmVirtQemu.dsc >> +++ b/ArmVirtPkg/ArmVirtQemu.dsc >> @@ -293,7 +293,10 @@ [Components.common] >> MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf >> MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf >> EmbeddedPkg/ResetRuntimeDxe/ResetRuntimeDxe.inf >> - EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf >> + EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf { >> + <LibraryClasses> >> + NULL|ArmVirtPkg/Library/ArmVirtPL031FdtClientLib/ArmVirtPL031FdtClientLib.inf >> + } >> EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf >> >> MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf >> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc >> index 2cbeced695f9..01029e38db3b 100644 >> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc >> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc >> @@ -271,7 +271,10 @@ [Components.common] >> MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf >> MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf >> EmbeddedPkg/ResetRuntimeDxe/ResetRuntimeDxe.inf >> - EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf >> + EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf { >> + <LibraryClasses> >> + NULL|ArmVirtPkg/Library/ArmVirtPL031FdtClientLib/ArmVirtPL031FdtClientLib.inf >> + } >> EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf >> >> MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf >> -- >> 2.5.0 >> _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On 13 April 2016 at 17:20, Laszlo Ersek <lersek@redhat.com> wrote: > On 04/13/16 17:13, Ard Biesheuvel wrote: >> On 13 April 2016 at 17:07, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: >>> This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no >>> longer have to rely on VirtFdtDxe to execute first and set the PL031 base >>> address in a dynamic PCD. >>> >>> The only driver which [transitively] depends on this PcdPL031RtcBase PCD is >>> EmbeddedPkg/RealTimeClockRuntimeDxe, so this conversion cannot affect any >>> other users and is thus safe. >>> >>> Contributed-under: TianoCore Contribution Agreement 1.0 >>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> >>> --- >>> >>> Laszlo, >>> >>> I did 'fix' it in v4, but poorly ... >>> >> >> ... or perhaps I didn't. Anyway, I managed to confuse myself >> thoroughly here, but in the end we both know what is wrong with the >> patch, so I will slap your R-b on the version below and push it out. >> >> Thanks for bearing with me here, > > Sure, no problem. I think that your refactoring is very valuable; it is > definitely an improvement that VIrtFdtDxe is no longer responsible for > every little thing that is described in the DT. > > It's just that -- I think! -- you didn't expect this rabbit hole to go > this deep, while I did. (Not sure why I expected it, but I did -- I > think I've struggled quite a lot with PCDs and NULL libs and ordering in > OvmfPkg.) > Precisely. I did not expect this to take up as much of our time as it did, which is also why I feel bad about wasting your time with my sloppiness. > I agree you should push the series. > Thanks. I pushed it just now. _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On 04/13/16 17:17, Laszlo Ersek wrote: > On 04/13/16 17:07, Ard Biesheuvel wrote: >> This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no >> longer have to rely on VirtFdtDxe to execute first and set the PL031 base >> address in a dynamic PCD. >> >> The only driver which [transitively] depends on this PcdPL031RtcBase PCD is >> EmbeddedPkg/RealTimeClockRuntimeDxe, so this conversion cannot affect any >> other users and is thus safe. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> >> --- >> >> Laszlo, >> >> I did 'fix' it in v4, but poorly ... >> >> You may have noticed that I am getting a bit impatient. > > Yes. > >> However, please >> don't mistake that for lack of respect. I highly value your review feedback, >> and have no complaints whatsoever about timeliness. > > I do hope that you don't have complaints about my response time, given > that I've been spending the overwhelming majority of my time, since you > posted v1 of this series, on reviewing your work. Frequently I've spent > 50 minutes or more pondering the plugin lib stuff, trying to verify if > things are safe, and writing up my thoughts. of course, over-editing led to the lossage of my point here: 50+ mins *per patch*. (Not for every patch, but for quite a few patches.) I'm sorry I requested so many updates. I tried to avoid splitting hairs, and I did my best to respond as quickly as I could. You didn't seem to disagree with most of my points. I wish I could have followed up even faster, but this stuff is just complex. _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On 13 April 2016 at 17:29, Laszlo Ersek <lersek@redhat.com> wrote: > On 04/13/16 17:17, Laszlo Ersek wrote: >> On 04/13/16 17:07, Ard Biesheuvel wrote: >>> This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no >>> longer have to rely on VirtFdtDxe to execute first and set the PL031 base >>> address in a dynamic PCD. >>> >>> The only driver which [transitively] depends on this PcdPL031RtcBase PCD is >>> EmbeddedPkg/RealTimeClockRuntimeDxe, so this conversion cannot affect any >>> other users and is thus safe. >>> >>> Contributed-under: TianoCore Contribution Agreement 1.0 >>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> >>> --- >>> >>> Laszlo, >>> >>> I did 'fix' it in v4, but poorly ... >>> >>> You may have noticed that I am getting a bit impatient. >> >> Yes. >> >>> However, please >>> don't mistake that for lack of respect. I highly value your review feedback, >>> and have no complaints whatsoever about timeliness. >> >> I do hope that you don't have complaints about my response time, given >> that I've been spending the overwhelming majority of my time, since you >> posted v1 of this series, on reviewing your work. Frequently I've spent >> 50 minutes or more pondering the plugin lib stuff, trying to verify if >> things are safe, and writing up my thoughts. > > of course, over-editing led to the lossage of my point here: 50+ mins > *per patch*. (Not for every patch, but for quite a few patches.) > > I'm sorry I requested so many updates. I tried to avoid splitting hairs, > and I did my best to respond as quickly as I could. You didn't seem to > disagree with most of my points. I wish I could have followed up even > faster, but this stuff is just complex. I *really* don't have any complaints about your response time or your level of scrutiny, and I think what we ultimately ended up with upstream is of much higher quality than my original v1. I just underestimated the amount of work (hey, I'm a developer) and got sloppy towards the end as a result. _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On 04/13/16 17:34, Ard Biesheuvel wrote: > On 13 April 2016 at 17:29, Laszlo Ersek <lersek@redhat.com> wrote: >> On 04/13/16 17:17, Laszlo Ersek wrote: >>> On 04/13/16 17:07, Ard Biesheuvel wrote: >>>> This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no >>>> longer have to rely on VirtFdtDxe to execute first and set the PL031 base >>>> address in a dynamic PCD. >>>> >>>> The only driver which [transitively] depends on this PcdPL031RtcBase PCD is >>>> EmbeddedPkg/RealTimeClockRuntimeDxe, so this conversion cannot affect any >>>> other users and is thus safe. >>>> >>>> Contributed-under: TianoCore Contribution Agreement 1.0 >>>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> >>>> --- >>>> >>>> Laszlo, >>>> >>>> I did 'fix' it in v4, but poorly ... >>>> >>>> You may have noticed that I am getting a bit impatient. >>> >>> Yes. >>> >>>> However, please >>>> don't mistake that for lack of respect. I highly value your review feedback, >>>> and have no complaints whatsoever about timeliness. >>> >>> I do hope that you don't have complaints about my response time, given >>> that I've been spending the overwhelming majority of my time, since you >>> posted v1 of this series, on reviewing your work. Frequently I've spent >>> 50 minutes or more pondering the plugin lib stuff, trying to verify if >>> things are safe, and writing up my thoughts. >> >> of course, over-editing led to the lossage of my point here: 50+ mins >> *per patch*. (Not for every patch, but for quite a few patches.) >> >> I'm sorry I requested so many updates. I tried to avoid splitting hairs, >> and I did my best to respond as quickly as I could. You didn't seem to >> disagree with most of my points. I wish I could have followed up even >> faster, but this stuff is just complex. > > I *really* don't have any complaints about your response time or your > level of scrutiny, and I think what we ultimately ended up with > upstream is of much higher quality than my original v1. I just > underestimated the amount of work (hey, I'm a developer) and got > sloppy towards the end as a result. Understood. :) It's all done now, everything's fine. Let's have some drinks (although we could only say "cheers!" on IRC); we deserve it! ;) Cheers! Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On 13 April 2016 at 17:40, Laszlo Ersek <lersek@redhat.com> wrote: > On 04/13/16 17:34, Ard Biesheuvel wrote: >> On 13 April 2016 at 17:29, Laszlo Ersek <lersek@redhat.com> wrote: >>> On 04/13/16 17:17, Laszlo Ersek wrote: >>>> On 04/13/16 17:07, Ard Biesheuvel wrote: >>>>> This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no >>>>> longer have to rely on VirtFdtDxe to execute first and set the PL031 base >>>>> address in a dynamic PCD. >>>>> >>>>> The only driver which [transitively] depends on this PcdPL031RtcBase PCD is >>>>> EmbeddedPkg/RealTimeClockRuntimeDxe, so this conversion cannot affect any >>>>> other users and is thus safe. >>>>> >>>>> Contributed-under: TianoCore Contribution Agreement 1.0 >>>>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> >>>>> --- >>>>> >>>>> Laszlo, >>>>> >>>>> I did 'fix' it in v4, but poorly ... >>>>> >>>>> You may have noticed that I am getting a bit impatient. >>>> >>>> Yes. >>>> >>>>> However, please >>>>> don't mistake that for lack of respect. I highly value your review feedback, >>>>> and have no complaints whatsoever about timeliness. >>>> >>>> I do hope that you don't have complaints about my response time, given >>>> that I've been spending the overwhelming majority of my time, since you >>>> posted v1 of this series, on reviewing your work. Frequently I've spent >>>> 50 minutes or more pondering the plugin lib stuff, trying to verify if >>>> things are safe, and writing up my thoughts. >>> >>> of course, over-editing led to the lossage of my point here: 50+ mins >>> *per patch*. (Not for every patch, but for quite a few patches.) >>> >>> I'm sorry I requested so many updates. I tried to avoid splitting hairs, >>> and I did my best to respond as quickly as I could. You didn't seem to >>> disagree with most of my points. I wish I could have followed up even >>> faster, but this stuff is just complex. >> >> I *really* don't have any complaints about your response time or your >> level of scrutiny, and I think what we ultimately ended up with >> upstream is of much higher quality than my original v1. I just >> underestimated the amount of work (hey, I'm a developer) and got >> sloppy towards the end as a result. > > Understood. :) > > It's all done now, everything's fine. Let's have some drinks (although > we could only say "cheers!" on IRC); we deserve it! ;) > > Cheers! > Laszlo > Cheers! _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc index c42092f54163..70419ff3f856 100644 --- a/ArmVirtPkg/ArmVirtQemu.dsc +++ b/ArmVirtPkg/ArmVirtQemu.dsc @@ -293,7 +293,10 @@ [Components.common] MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf EmbeddedPkg/ResetRuntimeDxe/ResetRuntimeDxe.inf - EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf + EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf { + <LibraryClasses> + NULL|ArmVirtPkg/Library/ArmVirtPL031FdtClientLib/ArmVirtPL031FdtClientLib.inf + } EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc index 2cbeced695f9..01029e38db3b 100644 --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc @@ -271,7 +271,10 @@ [Components.common] MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf EmbeddedPkg/ResetRuntimeDxe/ResetRuntimeDxe.inf - EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf + EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf { + <LibraryClasses> + NULL|ArmVirtPkg/Library/ArmVirtPL031FdtClientLib/ArmVirtPL031FdtClientLib.inf + } EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf
This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no longer have to rely on VirtFdtDxe to execute first and set the PL031 base address in a dynamic PCD. The only driver which [transitively] depends on this PcdPL031RtcBase PCD is EmbeddedPkg/RealTimeClockRuntimeDxe, so this conversion cannot affect any other users and is thus safe. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> --- Laszlo, I did 'fix' it in v4, but poorly ... You may have noticed that I am getting a bit impatient. However, please don't mistake that for lack of respect. I highly value your review feedback, and have no complaints whatsoever about timeliness. I just need a couple more hours in a day ... Thanks, Ard. ArmVirtPkg/ArmVirtQemu.dsc | 5 ++++- ArmVirtPkg/ArmVirtQemuKernel.dsc | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) -- 2.5.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel