| Message ID | 20230302154724.856062-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Accepted |
| Commit | a5982b3971007161b423b39aa843bdb6713a9d44 |
| Headers | show |
| Series | arm64: dts: qcom: sm8550: fix LPASS pinctrl slew base address | expand |
On Thu, 2 Mar 2023 16:47:24 +0100, Krzysztof Kozlowski wrote: > The second LPASS pin controller IO address is supposed to be the MCC > range which contains the slew rate registers. The Linux driver then > accesses slew rate register with hard-coded offset (0xa000). However > the DTS contained the address of slew rate register as the second IO > address, thus any reads were effectively pass the memory space and lead > to "Internal error: synchronous external aborts" when applying pin > configuration. > > [...] Applied, thanks! [1/1] arm64: dts: qcom: sm8550: fix LPASS pinctrl slew base address commit: a5982b3971007161b423b39aa843bdb6713a9d44 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi index 1dea055a6815..6296eb7adecd 100644 --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi @@ -2001,7 +2001,7 @@ IPCC_MPROC_SIGNAL_GLINK_QMP lpass_tlmm: pinctrl@6e80000 { compatible = "qcom,sm8550-lpass-lpi-pinctrl"; reg = <0 0x06e80000 0 0x20000>, - <0 0x0725a000 0 0x10000>; + <0 0x07250000 0 0x10000>; gpio-controller; #gpio-cells = <2>; gpio-ranges = <&lpass_tlmm 0 0 23>;
The second LPASS pin controller IO address is supposed to be the MCC range which contains the slew rate registers. The Linux driver then accesses slew rate register with hard-coded offset (0xa000). However the DTS contained the address of slew rate register as the second IO address, thus any reads were effectively pass the memory space and lead to "Internal error: synchronous external aborts" when applying pin configuration. Fixes: 6de7f9c34358 ("arm64: dts: qcom: sm8550: add GPR and LPASS pin controller") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Fix for current cycle - v6.3-rc1. --- arch/arm64/boot/dts/qcom/sm8550.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)