diff mbox series

media: venus: fix use after free bug in venus_remove due to race condition

Message ID 20230308071105.2130297-1-zyytlz.wz@163.com
State Superseded
Headers show
Series media: venus: fix use after free bug in venus_remove due to race condition | expand

Commit Message

Zheng Wang March 8, 2023, 7:11 a.m. UTC
in venus_probe, core->work is bound with venus_sys_error_handler, which is
used to handle error. The code use core->sys_err_done to make sync work.
The core->work is started in venus_event_notify.

If we call venus_remove, there might be a unfished work. The core->lock may
be destroyed in venus_remove and used in venus_sys_error_handler.

Fix it by canceling the work first in venus_remove.

Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
---
 drivers/media/platform/qcom/venus/core.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
index 990a1519f968..54ace8bf45e7 100644
--- a/drivers/media/platform/qcom/venus/core.c
+++ b/drivers/media/platform/qcom/venus/core.c
@@ -423,6 +423,7 @@  static int venus_remove(struct platform_device *pdev)
 	struct device *dev = core->dev;
 	int ret;
 
+	cancel_delayed_work(&core->work);
 	ret = pm_runtime_get_sync(dev);
 	WARN_ON(ret < 0);