diff mbox

man: Clarify virsh vol-clone works within a single pool

Message ID a1088b2a9f908b588852e8df5c23b1aa07bc9747.1461101759.git.crobinso@redhat.com
State Accepted
Commit 2f1dc3de4672f4d7aa42bb4984618d382388e0d2
Headers show

Commit Message

Cole Robinson April 19, 2016, 9:35 p.m. UTC 
virsh vol-clone is expected to clone a volume within a single
pool; it doesn't work for cloning across pools. Clarify the docs

https://bugzilla.redhat.com/show_bug.cgi?id=1103714
---
 tools/virsh-volume.c | 2 +-
 tools/virsh.pod      | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.7.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Comments

Cole Robinson April 20, 2016, 1:14 p.m. UTC | #1 
On 04/20/2016 03:36 AM, Jiri Denemark wrote:
> On Tue, Apr 19, 2016 at 17:35:59 -0400, Cole Robinson wrote:

>> virsh vol-clone is expected to clone a volume within a single

>> pool; it doesn't work for cloning across pools. Clarify the docs

>>

>> https://bugzilla.redhat.com/show_bug.cgi?id=1103714

> ...

>> diff --git a/tools/virsh.pod b/tools/virsh.pod

>> index 6c9d4ec..e1c0d8e 100644

>> --- a/tools/virsh.pod

>> +++ b/tools/virsh.pod

>> @@ -3530,10 +3530,10 @@ only slightly higher initial disk space usage.

>>  =item B<vol-clone> [I<--pool> I<pool-or-uuid>] I<vol-name-or-key-or-path>

>>  I<name> [I<--prealloc-metadata>] [I<--reflink>]

>>  

>> -Clone an existing volume.  Less powerful, but easier to type, version of

>> -B<vol-create-from>.

>> +Clone an existing volume within the parent pool.  Less powerful,

>> +but easier to type, version of B<vol-create-from>.

>>  I<--pool> I<pool-or-uuid> is the name or UUID of the storage pool to create

> 

> I think you also want to drop " to create" :-)

> 

>> -the volume in.

>> +that contains the source volume, and will contain the new volume.

>>  I<vol-name-or-key-or-path> is the name or key or path of the source volume.

>>  I<name> is the name of the new volume.

>>  [I<--prealloc-metadata>] preallocate metadata (for qcow2 images which don't

> 

> ACK with the small tweak.

> 


Thanks, pushed with that fix

- Cole

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
diff mbox

Patch

diff --git a/tools/virsh-volume.c b/tools/virsh-volume.c
index 36dd0ed..9cc8e52 100644
--- a/tools/virsh-volume.c
+++ b/tools/virsh-volume.c
@@ -546,7 +546,7 @@  static const vshCmdInfo info_vol_clone[] = {
      .data = N_("clone a volume.")
     },
     {.name = "desc",
-     .data = N_("Clone an existing volume.")
+     .data = N_("Clone an existing volume within the parent pool.")
     },
     {.name = NULL}
 };
diff --git a/tools/virsh.pod b/tools/virsh.pod
index 6c9d4ec..e1c0d8e 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -3530,10 +3530,10 @@  only slightly higher initial disk space usage.
 =item B<vol-clone> [I<--pool> I<pool-or-uuid>] I<vol-name-or-key-or-path>
 I<name> [I<--prealloc-metadata>] [I<--reflink>]
 
-Clone an existing volume.  Less powerful, but easier to type, version of
-B<vol-create-from>.
+Clone an existing volume within the parent pool.  Less powerful,
+but easier to type, version of B<vol-create-from>.
 I<--pool> I<pool-or-uuid> is the name or UUID of the storage pool to create
-the volume in.
+that contains the source volume, and will contain the new volume.
 I<vol-name-or-key-or-path> is the name or key or path of the source volume.
 I<name> is the name of the new volume.
 [I<--prealloc-metadata>] preallocate metadata (for qcow2 images which don't