| Message ID | 1461264539-6798-1-git-send-email-zoltan.kiss@linaro.org |
|---|---|
| State | Accepted |
| Commit | 7a2686c3e6ca06068fc8eafee7c4478f1f116724 |
| Headers | show |
diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c index d52a520..78cf44a 100644 --- a/test/validation/pktio/pktio.c +++ b/test/validation/pktio/pktio.c @@ -1258,8 +1258,6 @@ void pktio_test_statistics_counters(void) CU_ASSERT(ret == 0); CU_ASSERT((stats[1].in_ucast_pkts == 0) || (stats[1].in_ucast_pkts >= (uint64_t)pkts)); - CU_ASSERT(stats[0].out_ucast_pkts == stats[1].in_ucast_pkts); - CU_ASSERT(stats[0].out_octets == stats[1].in_octets); CU_ASSERT((stats[0].out_octets == 0) || (stats[0].out_octets >= (PKT_LEN_NORMAL * (uint64_t)pkts)));
This test sets up two interfaces and connect them to each other, so in theory these numbers should be the same. However when you use a pktio which doesn't have full control of the interface, it could happen that other players, e.g. various services of the operating system start to send traffic out on the newly created interfaces. It won't be visible for ODP when going out, but coming in it will increase the counters. This breaks the test on ODP-DPDK, unnecessarily. On ODP-Linux it does not, because it checks the system level statistics, not the ODP level ones. Signed-off-by: Zoltan Kiss <zoltan.kiss@linaro.org> --- v2: - fix commit log typo - remove pkt number check as well, and edit the title