mbox series

[GIT,PULL,FOR,v6.4] v2: Drop destructive overlay support

Message ID 7aafb16c-d6a0-f62d-dfbd-05ef87d0a5e5@xs4all.nl
State New
Headers show
Series [GIT,PULL,FOR,v6.4] v2: Drop destructive overlay support | expand

Pull-request

git://linuxtv.org/hverkuil/media_tree.git tags/br-v6.4b

Message

Hans Verkuil March 16, 2023, 5:43 p.m. UTC
See the cover letter for more info:

https://patchwork.linuxtv.org/project/linux-media/cover/20230302125731.1124945-1-hverkuil-cisco@xs4all.nl/

Regards,

	Hans

Changes since v1:

- rebased to 6.3-rc2
- fix an ENUM_FMT regression in bttv where the format index was returned
  instead of 0. Thanks to Deb Brouwer for reporting this!


The following changes since commit eeac8ede17557680855031c6f305ece2378af326:

  Linux 6.3-rc2 (2023-03-12 16:36:44 -0700)

are available in the Git repository at:

  git://linuxtv.org/hverkuil/media_tree.git tags/br-v6.4b

for you to fetch changes up to 4fb898a32be9ce2c0dfbb4ff3b3cb83626d00421:

  Documentation: userspace-api: media: drop clipping, destructive overlays (2023-03-16 17:43:14 +0100)

----------------------------------------------------------------
Tag branch

----------------------------------------------------------------
Hans Verkuil (9):
      saa7146: drop overlay support
      saa7134: drop overlay support
      bttv: drop overlay support
      vivid: drop overlay support
      vivid: drop bitmap and clipping output overlay support
      v4l2-core: drop v4l2_window clipping and bitmap support
      videodev.h: drop V4L2_FBUF_CAP_LIST/BITMAP_CLIPPING
      v4l2-core: zero field base in struct v4l2_framebuffer
      Documentation: userspace-api: media: drop clipping, destructive overlays

 Documentation/userspace-api/media/v4l/dev-overlay.rst   |  10 +-
 Documentation/userspace-api/media/v4l/vidioc-g-fbuf.rst |  52 +++----
 drivers/media/common/saa7146/saa7146_fops.c             |  26 +---
 drivers/media/common/saa7146/saa7146_hlp.c              | 296 ----------------------------------------
 drivers/media/common/saa7146/saa7146_video.c            | 326 +-------------------------------------------
 drivers/media/pci/bt8xx/Kconfig                         |   2 +-
 drivers/media/pci/bt8xx/btcx-risc.c                     | 153 ---------------------
 drivers/media/pci/bt8xx/btcx-risc.h                     |   9 --
 drivers/media/pci/bt8xx/bttv-cards.c                    |  15 --
 drivers/media/pci/bt8xx/bttv-driver.c                   | 436 ++---------------------------------------------------------
 drivers/media/pci/bt8xx/bttv-risc.c                     | 131 ------------------
 drivers/media/pci/bt8xx/bttvp.h                         |  28 +---
 drivers/media/pci/saa7134/saa7134-cards.c               |   1 -
 drivers/media/pci/saa7134/saa7134-core.c                |  32 -----
 drivers/media/pci/saa7134/saa7134-video.c               | 411 +------------------------------------------------------
 drivers/media/pci/saa7134/saa7134.h                     |  13 --
 drivers/media/test-drivers/vivid/vivid-core.c           |  49 +------
 drivers/media/test-drivers/vivid/vivid-core.h           |  19 ---
 drivers/media/test-drivers/vivid/vivid-kthread-cap.c    | 131 +-----------------
 drivers/media/test-drivers/vivid/vivid-vid-cap.c        | 272 -------------------------------------
 drivers/media/test-drivers/vivid/vivid-vid-cap.h        |   3 -
 drivers/media/test-drivers/vivid/vivid-vid-out.c        |  74 ----------
 drivers/media/v4l2-core/v4l2-compat-ioctl32.c           |  85 ++----------
 drivers/media/v4l2-core/v4l2-ioctl.c                    |  77 ++++-------
 drivers/staging/media/av7110/av7110_v4l.c               |  17 +--
 include/media/drv-intf/saa7146_vv.h                     |  21 ---
 include/uapi/linux/videodev2.h                          |   2 +
 27 files changed, 92 insertions(+), 2599 deletions(-)

Comments

Jenkins March 19, 2023, 3:06 p.m. UTC | #1
From: builder@linuxtv.org

Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/7aafb16c-d6a0-f62d-dfbd-05ef87d0a5e5@xs4all.nl/
Build log: https://builder.linuxtv.org/job/patchwork/290890/
Build time: 00:35:03
Link: https://lore.kernel.org/linux-media/7aafb16c-d6a0-f62d-dfbd-05ef87d0a5e5@xs4all.nl

gpg: Signature made Thu 16 Mar 2023 04:43:59 PM UTC
gpg:                using EDDSA key 52ADCAAE8A4F70B99ACD8D726B425DF79B1C1E76
gpg: Good signature from "Hans Verkuil <hverkuil-cisco@xs4all.nl>" [unknown]
gpg:                 aka "Hans Verkuil <hverkuil@xs4all.nl>" [full]

Summary: got 4/9 patches with issues, being 2 at build time, plus one error when buinding PDF document

Error/warnings:

patches/0001-saa7146-drop-overlay-support.patch:

    allyesconfig: return code #0:
	../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
	../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
	../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples
	../drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:415 ov2680_s_stream() warn: missing error code 'ret'
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3357 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3456 atomisp_cp_morph_table() warn: missing unwind goto?

    allyesconfig: return code #0:
	../drivers/media/i2c/adp1653.c: ../drivers/media/i2c/adp1653.c:444 adp1653_of_init() warn: missing unwind goto?
	../drivers/media/i2c/ov5645.c: ../drivers/media/i2c/ov5645.c:687 ov5645_set_power_on() warn: 'ov5645->xclk' from clk_prepare_enable() not released on lines: 687.
	../drivers/media/i2c/ov5670.c: ../drivers/media/i2c/ov5670.c:2670 ov5670_probe() warn: passing zero to 'PTR_ERR'
	SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures
	../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c: ../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c:2485 mxc_jpeg_probe() warn: missing unwind goto?
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() parse error: OOM: 3000032Kb sm_state_count = 1941110
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() warn: Function too hairy.  No more merges.
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() parse error: __split_smt: function too hairy.  Giving up after 54 seconds
	../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2864 em28xx_v4l2_init() parse error: turning off implications after 60 seconds
	../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3293 pvr2_hdw_get_tuner_status() warn: inconsistent indenting

patches/0003-bttv-drop-overlay-support.patch:

   checkpatch.pl:
	$ cat patches/0003-bttv-drop-overlay-support.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:298: WARNING: please, no spaces at the start of a line
	-:298: CHECK: Avoid CamelCase: <This>

patches/0006-v4l2-core-drop-v4l2_window-clipping-and-bitmap-suppo.patch:

   checkpatch.pl:
	$ cat patches/0006-v4l2-core-drop-v4l2_window-clipping-and-bitmap-suppo.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:158: WARNING: Avoid logging continuation uses where feasible

patches/0007-videodev.h-drop-V4L2_FBUF_CAP_LIST-BITMAP_CLIPPING.patch:

    allyesconfig: return code #0:
	../drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:415 ov2680_s_stream() warn: missing error code 'ret'
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3357 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3456 atomisp_cp_morph_table() warn: missing unwind goto?

    allyesconfig: return code #0:
	../drivers/media/i2c/adp1653.c: ../drivers/media/i2c/adp1653.c:444 adp1653_of_init() warn: missing unwind goto?
	../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c: ../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c:2485 mxc_jpeg_probe() warn: missing unwind goto?
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() parse error: OOM: 3000028Kb sm_state_count = 1939314
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() warn: Function too hairy.  No more merges.
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() parse error: __split_smt: function too hairy.  Giving up after 51 seconds
	../drivers/media/i2c/ov5645.c: ../drivers/media/i2c/ov5645.c:687 ov5645_set_power_on() warn: 'ov5645->xclk' from clk_prepare_enable() not released on lines: 687.
	../drivers/media/i2c/ov5670.c: ../drivers/media/i2c/ov5670.c:2670 ov5670_probe() warn: passing zero to 'PTR_ERR'
	../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3293 pvr2_hdw_get_tuner_status() warn: inconsistent indenting
	../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2878 em28xx_v4l2_init() parse error: turning off implications after 60 seconds


Error #512 when building PDF docs