| Message ID | 20230324073813.22158-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Accepted |
| Commit | dffc4b5c086cf1d3dae4761427122a56b9d1253a |
| Headers | show |
| Series | [1/6] arm64: dts: qcom: sm8250: drop incorrect domain idle states properties | expand |
On 24/03/2023 09:38, Krzysztof Kozlowski wrote: > Domain idle states do not use 'idle-state-name' and 'local-timer-stop': > > sm8250-hdk.dtb: domain-idle-states: cluster-sleep-0: 'idle-state-name', 'local-timer-stop' do not match any of the regexes: 'pinctrl-[0-9]+' > > Reported-by: Neil Armstrong <neil.armstrong@linaro.org> > Link: https://lore.kernel.org/all/20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-4-3ead1e418fe4@linaro.org/ > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index 79d67b466856..9cf2de87c632 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -354,12 +354,10 @@ BIG_CPU_SLEEP_0: cpu-sleep-1-0 { > domain-idle-states { > CLUSTER_SLEEP_0: cluster-sleep-0 { > compatible = "domain-idle-state"; > - idle-state-name = "cluster-llcc-off"; > arm,psci-suspend-param = <0x4100c244>; > entry-latency-us = <3264>; > exit-latency-us = <6562>; > min-residency-us = <9987>; > - local-timer-stop; Hmm, so we support setting the broadcast timer when using plain PSCI idle states, but not when using the domain-based idle states. Ulf, Rafael, Daniel, is that an omission for the domain-based idle support? Or is it handled in some other way? > }; > }; > };
diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi index 79d67b466856..9cf2de87c632 100644 --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi @@ -354,12 +354,10 @@ BIG_CPU_SLEEP_0: cpu-sleep-1-0 { domain-idle-states { CLUSTER_SLEEP_0: cluster-sleep-0 { compatible = "domain-idle-state"; - idle-state-name = "cluster-llcc-off"; arm,psci-suspend-param = <0x4100c244>; entry-latency-us = <3264>; exit-latency-us = <6562>; min-residency-us = <9987>; - local-timer-stop; }; }; };
Domain idle states do not use 'idle-state-name' and 'local-timer-stop': sm8250-hdk.dtb: domain-idle-states: cluster-sleep-0: 'idle-state-name', 'local-timer-stop' do not match any of the regexes: 'pinctrl-[0-9]+' Reported-by: Neil Armstrong <neil.armstrong@linaro.org> Link: https://lore.kernel.org/all/20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-4-3ead1e418fe4@linaro.org/ Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 -- 1 file changed, 2 deletions(-)