diff mbox

[API-NEXTv2,1/2] api: pktio: Adds interface loopback mode

Message ID 1461672525-11516-1-git-send-email-bala.manoharan@linaro.org
State Accepted
Commit 627d963535ece15058324e6f88eb02bf5abf49dc
Headers show

Commit Message

Balasubramanian Manoharan April 26, 2016, 12:08 p.m. UTC
Adds loopback interface mode as a configurable parameter in pktio
configuration parameter. Support for loopback is an optional feature and
should be checked in the interface capability before enabling the same.

Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org>
---
v2: Incorporates review comments from Petri
 include/odp/api/spec/packet_io.h | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Maxim Uvarov April 26, 2016, 2:51 p.m. UTC | #1
Merged,
Maxim.

On 04/26/16 15:25, Savolainen, Petri (Nokia - FI/Espoo) wrote:
> Both patches:
>
> Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com>
>
>
>> -----Original Message-----
>> From: EXT Balasubramanian Manoharan [mailto:bala.manoharan@linaro.org]
>> Sent: Tuesday, April 26, 2016 3:09 PM
>> To: lng-odp@lists.linaro.org
>> Cc: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia.com>;
>> Balasubramanian Manoharan <bala.manoharan@linaro.org>
>> Subject: [PATCH API-NEXTv2 1/2] api: pktio: Adds interface loopback mode
>>
>> Adds loopback interface mode as a configurable parameter in pktio
>> configuration parameter. Support for loopback is an optional feature and
>> should be checked in the interface capability before enabling the same.
>>
>> Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org>
>> ---
>> v2: Incorporates review comments from Petri
>>   include/odp/api/spec/packet_io.h | 14 ++++++++++++++
>>   1 file changed, 14 insertions(+)
>>
>> diff --git a/include/odp/api/spec/packet_io.h
>> b/include/odp/api/spec/packet_io.h
>> index 7c29176..1899a4f 100644
>> --- a/include/odp/api/spec/packet_io.h
>> +++ b/include/odp/api/spec/packet_io.h
>> @@ -362,6 +362,14 @@ typedef struct odp_pktio_config_t {
>>   	 *  Default value for all bits is zero. */
>>   	odp_pktout_config_opt_t pktout;
>>
>> +	/** Interface loopback mode
>> +	 *
>> +	 * In this mode the packets sent out through the interface is
>> +	 * looped back to input of the same interface. Supporting loopback
>> mode
>> +	 * is an optional feature per interface and should be queried in the
>> +	 * interface capability before enabling the same. */
>> +	odp_bool_t enable_loop;
>> +
>>   } odp_pktio_config_t;
>>
>>   /**
>> @@ -399,6 +407,12 @@ typedef struct odp_pktio_capability_t {
>>   	 * A bit set to one indicates a supported operation. All other bits
>> are
>>   	 * set to zero. */
>>   	odp_pktio_set_op_t set_op;
>> +
>> +	/** Support of Loopback mode
>> +	 *
>> +	 * A boolean to denote whether loop back mode is supported on this
>> +	 * specific interface. */
>> +	odp_bool_t loop_supported;
>>   } odp_pktio_capability_t;
>>
>>   /**
>> --
>> 1.9.1
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
diff mbox

Patch

diff --git a/include/odp/api/spec/packet_io.h b/include/odp/api/spec/packet_io.h
index 7c29176..1899a4f 100644
--- a/include/odp/api/spec/packet_io.h
+++ b/include/odp/api/spec/packet_io.h
@@ -362,6 +362,14 @@  typedef struct odp_pktio_config_t {
 	 *  Default value for all bits is zero. */
 	odp_pktout_config_opt_t pktout;
 
+	/** Interface loopback mode
+	 *
+	 * In this mode the packets sent out through the interface is
+	 * looped back to input of the same interface. Supporting loopback mode
+	 * is an optional feature per interface and should be queried in the
+	 * interface capability before enabling the same. */
+	odp_bool_t enable_loop;
+
 } odp_pktio_config_t;
 
 /**
@@ -399,6 +407,12 @@  typedef struct odp_pktio_capability_t {
 	 * A bit set to one indicates a supported operation. All other bits are
 	 * set to zero. */
 	odp_pktio_set_op_t set_op;
+
+	/** Support of Loopback mode
+	 *
+	 * A boolean to denote whether loop back mode is supported on this
+	 * specific interface. */
+	odp_bool_t loop_supported;
 } odp_pktio_capability_t;
 
 /**