| Message ID | 1461716234-31105-1-git-send-email-bill.fischofer@linaro.org |
|---|---|
| State | Accepted |
| Commit | 481f5e6813a4c820989cca9cfa260096382361ed |
| Headers | show |
Ping. Needs review for inclusion in Monarch RC2. On Tue, Apr 26, 2016 at 7:17 PM, Bill Fischofer <bill.fischofer@linaro.org> wrote: > Add touch tests for the following APIs: > odp_packet_has_l2_error() > odp_packet_has_l3_error() > odp_packet_has_l4_error() > > Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org> > --- > test/validation/packet/packet.c | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/test/validation/packet/packet.c > b/test/validation/packet/packet.c > index 4b9da46..180250a 100644 > --- a/test/validation/packet/packet.c > +++ b/test/validation/packet/packet.c > @@ -627,12 +627,21 @@ void packet_test_error_flags(void) > int err; > > /** > - * The packet have not been classified so it doesn't have error > flag > - * properly set. Just check that function return one of allowed > values. > - * @todo: check classified packet when classifier is added in > place. > + * The packet have not been classified so it doesn't have error > flags > + * properly set. Just check that functions return one of allowed > values. > + * @todo: try with known good and bad packets. > */ > err = odp_packet_has_error(pkt); > CU_ASSERT(err == 0 || err == 1); > + > + err = odp_packet_has_l2_error(pkt); > + CU_ASSERT(err == 0 || err == 1); > + > + err = odp_packet_has_l3_error(pkt); > + CU_ASSERT(err == 0 || err == 1); > + > + err = odp_packet_has_l4_error(pkt); > + CU_ASSERT(err == 0 || err == 1); > } > > struct packet_metadata { > -- > 2.5.0 > >
Reviewed-by: Balasubramanian Manoharan <bala.manoharan@linaro.org> On 27 April 2016 at 05:47, Bill Fischofer <bill.fischofer@linaro.org> wrote: > Add touch tests for the following APIs: > odp_packet_has_l2_error() > odp_packet_has_l3_error() > odp_packet_has_l4_error() > > Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org> > --- > test/validation/packet/packet.c | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/test/validation/packet/packet.c > b/test/validation/packet/packet.c > index 4b9da46..180250a 100644 > --- a/test/validation/packet/packet.c > +++ b/test/validation/packet/packet.c > @@ -627,12 +627,21 @@ void packet_test_error_flags(void) > int err; > > /** > - * The packet have not been classified so it doesn't have error > flag > - * properly set. Just check that function return one of allowed > values. > - * @todo: check classified packet when classifier is added in > place. > + * The packet have not been classified so it doesn't have error > flags > + * properly set. Just check that functions return one of allowed > values. > + * @todo: try with known good and bad packets. > */ > err = odp_packet_has_error(pkt); > CU_ASSERT(err == 0 || err == 1); > + > + err = odp_packet_has_l2_error(pkt); > + CU_ASSERT(err == 0 || err == 1); > + > + err = odp_packet_has_l3_error(pkt); > + CU_ASSERT(err == 0 || err == 1); > + > + err = odp_packet_has_l4_error(pkt); > + CU_ASSERT(err == 0 || err == 1); > } > > struct packet_metadata { > -- > 2.5.0 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp >
Merged, Maxim. On 04/28/16 10:16, Bala Manoharan wrote: > Reviewed-by: Balasubramanian Manoharan <bala.manoharan@linaro.org > <mailto:bala.manoharan@linaro.org>> > > On 27 April 2016 at 05:47, Bill Fischofer <bill.fischofer@linaro.org > <mailto:bill.fischofer@linaro.org>> wrote: > > Add touch tests for the following APIs: > odp_packet_has_l2_error() > odp_packet_has_l3_error() > odp_packet_has_l4_error() > > Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org > <mailto:bill.fischofer@linaro.org>> > --- > test/validation/packet/packet.c | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/test/validation/packet/packet.c > b/test/validation/packet/packet.c > index 4b9da46..180250a 100644 > --- a/test/validation/packet/packet.c > +++ b/test/validation/packet/packet.c > @@ -627,12 +627,21 @@ void packet_test_error_flags(void) > int err; > > /** > - * The packet have not been classified so it doesn't have > error flag > - * properly set. Just check that function return one of > allowed values. > - * @todo: check classified packet when classifier is added > in place. > + * The packet have not been classified so it doesn't have > error flags > + * properly set. Just check that functions return one of > allowed values. > + * @todo: try with known good and bad packets. > */ > err = odp_packet_has_error(pkt); > CU_ASSERT(err == 0 || err == 1); > + > + err = odp_packet_has_l2_error(pkt); > + CU_ASSERT(err == 0 || err == 1); > + > + err = odp_packet_has_l3_error(pkt); > + CU_ASSERT(err == 0 || err == 1); > + > + err = odp_packet_has_l4_error(pkt); > + CU_ASSERT(err == 0 || err == 1); > } > > struct packet_metadata { > -- > 2.5.0 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > https://lists.linaro.org/mailman/listinfo/lng-odp > > > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp
diff --git a/test/validation/packet/packet.c b/test/validation/packet/packet.c index 4b9da46..180250a 100644 --- a/test/validation/packet/packet.c +++ b/test/validation/packet/packet.c @@ -627,12 +627,21 @@ void packet_test_error_flags(void) int err; /** - * The packet have not been classified so it doesn't have error flag - * properly set. Just check that function return one of allowed values. - * @todo: check classified packet when classifier is added in place. + * The packet have not been classified so it doesn't have error flags + * properly set. Just check that functions return one of allowed values. + * @todo: try with known good and bad packets. */ err = odp_packet_has_error(pkt); CU_ASSERT(err == 0 || err == 1); + + err = odp_packet_has_l2_error(pkt); + CU_ASSERT(err == 0 || err == 1); + + err = odp_packet_has_l3_error(pkt); + CU_ASSERT(err == 0 || err == 1); + + err = odp_packet_has_l4_error(pkt); + CU_ASSERT(err == 0 || err == 1); } struct packet_metadata {
Add touch tests for the following APIs: odp_packet_has_l2_error() odp_packet_has_l3_error() odp_packet_has_l4_error() Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org> --- test/validation/packet/packet.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-)