| Message ID | 87fs9r6ktm.wl-kuninori.morimoto.gx@renesas.com |
|---|---|
| State | New |
| Headers | show |
| Series | ASoC: da7213.c: add missing pm_runtime_disable() | expand |
Hi Mark > > da7213.c is missing pm_runtime_disable(), thus we will get > > below error when rmmod -> insmod. This patch solves it. > > > > $ rmmod snd-soc-da7213.ko > > $ insmod snd-soc-da7213.ko > > da7213 0-001a: Unbalanced pm_runtime_enable!" > > > > [Kuninori adjusted to latest upstream] > > > > Signed-off-by: Duy Nguyen <duy.nguyen.rh@renesas.com> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Tested-by: Khanh Le <khanh.le.xr@renesas.com> > > If Duy originally wrote the patch it should have a From: line > saying they wrote it (they should be the commit author in your > local git, in which case git send-email will do the right thing). Oops, indeed. Thank you for pointing it. Will post v2 patch. Thank you for your help !! Best regards --- Kuninori Morimoto
diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c index 0068780fe0a7..1c1f211a8e2e 100644 --- a/sound/soc/codecs/da7213.c +++ b/sound/soc/codecs/da7213.c @@ -2022,6 +2022,11 @@ static int da7213_i2c_probe(struct i2c_client *i2c) return ret; } +static void da7213_i2c_remove(struct i2c_client *i2c) +{ + pm_runtime_disable(&i2c->dev); +} + static int __maybe_unused da7213_runtime_suspend(struct device *dev) { struct da7213_priv *da7213 = dev_get_drvdata(dev); @@ -2065,6 +2070,7 @@ static struct i2c_driver da7213_i2c_driver = { .pm = &da7213_pm, }, .probe_new = da7213_i2c_probe, + .remove = da7213_i2c_remove, .id_table = da7213_i2c_id, };