| Message ID | 20230401220810.3563708-4-dmitry.baryshkov@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: qcom: remove duplication in PMIC declarations | expand |
On Sun, Apr 02, 2023 at 01:07:51AM +0300, Dmitry Baryshkov wrote: > Following the commit c0ee8e0ba5cc ("arm64: dts: qcom: pmk8350: Use the > correct PON compatible") and commit f46ef374e0dc ("arm64: dts: qcom: > pmk8350: Specify PBS register for PON") use "qcom,pmk8350-pon" compat > string and add RBS region to the PON device. > > Fixes: ccd3517faf18 ("arm64: dts: qcom: sc8280xp: Add reference device") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> I already sent a fix for this last Monday: https://lore.kernel.org/all/20230327122948.4323-1-johan+linaro@kernel.org/ > --- > arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi > index c35e7f6bd657..a3c7369f9594 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi > @@ -59,8 +59,8 @@ pmk8280: pmic@0 { > #size-cells = <0>; > > pmk8280_pon: pon@1300 { > - compatible = "qcom,pm8998-pon"; > - reg = <0x1300>; > + compatible = "qcom,pmk8350-pon"; > + reg = <0x1300>, <0x800>; This is missing 'reg-names'. > > pmk8280_pon_pwrkey: pwrkey { > compatible = "qcom,pmk8350-pwrkey"; Johan
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi index c35e7f6bd657..a3c7369f9594 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi @@ -59,8 +59,8 @@ pmk8280: pmic@0 { #size-cells = <0>; pmk8280_pon: pon@1300 { - compatible = "qcom,pm8998-pon"; - reg = <0x1300>; + compatible = "qcom,pmk8350-pon"; + reg = <0x1300>, <0x800>; pmk8280_pon_pwrkey: pwrkey { compatible = "qcom,pmk8350-pwrkey";
Following the commit c0ee8e0ba5cc ("arm64: dts: qcom: pmk8350: Use the correct PON compatible") and commit f46ef374e0dc ("arm64: dts: qcom: pmk8350: Specify PBS register for PON") use "qcom,pmk8350-pon" compat string and add RBS region to the PON device. Fixes: ccd3517faf18 ("arm64: dts: qcom: sc8280xp: Add reference device") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)