diff mbox series

ASoC: SOF: Intel: hda-dai: Print the format_val as hexadecimal number

Message ID 20230406155219.18997-1-pierre-louis.bossart@linux.intel.com
State New
Headers show
Series ASoC: SOF: Intel: hda-dai: Print the format_val as hexadecimal number | expand

Commit Message

Pierre-Louis Bossart April 6, 2023, 3:52 p.m. UTC 
From: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

The format_val is a set of bitfileds, printing it as a decimal just makes
interpreting it complicated.

In other HDA core code the format_val is printed as hexadecimal also.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Jaska Uimonen <jaska.uimonen@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
---
 sound/soc/sof/intel/hda-dai.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Mark Brown April 6, 2023, 8:14 p.m. UTC | #1 
On Thu, 06 Apr 2023 10:52:19 -0500, Pierre-Louis Bossart wrote:
> The format_val is a set of bitfileds, printing it as a decimal just makes
> interpreting it complicated.
> 
> In other HDA core code the format_val is printed as hexadecimal also.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: SOF: Intel: hda-dai: Print the format_val as hexadecimal number
      commit: ef736f30548951870e2a5bfc41b6b0bb1d455641

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/sound/soc/sof/intel/hda-dai.c b/sound/soc/sof/intel/hda-dai.c
index 0435b7f251aa..44a5d94c5050 100644
--- a/sound/soc/sof/intel/hda-dai.c
+++ b/sound/soc/sof/intel/hda-dai.c
@@ -177,8 +177,8 @@  static int hda_link_dma_hw_params(struct snd_pcm_substream *substream,
 	format_val = snd_hdac_calc_stream_format(params_rate(params), params_channels(params),
 						 params_format(params), link_bps, 0);
 
-	dev_dbg(bus->dev, "format_val=%d, rate=%d, ch=%d, format=%d\n",
-		format_val, params_rate(params), params_channels(params), params_format(params));
+	dev_dbg(bus->dev, "format_val=%#x, rate=%d, ch=%d, format=%d\n", format_val,
+		params_rate(params), params_channels(params), params_format(params));
 
 	if (ops->setup_hext_stream)
 		ops->setup_hext_stream(sdev, hext_stream, format_val);