diff mbox series

[1/4] arm64: dts: qcom: sm8150: drop incorrect serial properties

Message ID 20230416151311.346596-1-krzysztof.kozlowski@linaro.org
State Superseded
Headers show
Series [1/4] arm64: dts: qcom: sm8150: drop incorrect serial properties | expand

Commit Message

Krzysztof Kozlowski April 16, 2023, 3:13 p.m. UTC
Drop incorrect and unused serial properties - address/size-cells and
reg-names:

  sa8155p-adp.dtb: geniqup@ac0000: serial@a84000: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'reg-names' were unexpected)

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8150.dtsi | 3 ---
 1 file changed, 3 deletions(-)

Comments

Konrad Dybcio April 17, 2023, 7:15 a.m. UTC | #1
On 16.04.2023 17:13, Krzysztof Kozlowski wrote:
> Drop incorrect and unused serial properties - address/size-cells and
> reg-names:
> 
>   sa8155p-adp.dtb: geniqup@ac0000: serial@a84000: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'reg-names' were unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sm8150.dtsi | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> index 27dcda0d4288..3846f5e0f656 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> @@ -1362,14 +1362,11 @@ spi9: spi@a84000 {
>  			uart9: serial@a84000 {
>  				compatible = "qcom,geni-uart";
>  				reg = <0x0 0x00a84000 0x0 0x4000>;
> -				reg-names = "se";
>  				clocks = <&gcc GCC_QUPV3_WRAP1_S1_CLK>;
>  				clock-names = "se";
>  				pinctrl-0 = <&qup_uart9_default>;
>  				pinctrl-names = "default";
>  				interrupts = <GIC_SPI 354 IRQ_TYPE_LEVEL_HIGH>;
> -				#address-cells = <1>;
> -				#size-cells = <0>;
>  				status = "disabled";
>  			};
>
Konrad Dybcio April 17, 2023, 7:17 a.m. UTC | #2
On 16.04.2023 17:13, Krzysztof Kozlowski wrote:
> GIC child node is supposed to be named msi-controller:
> 
>   sa8295p-adp.dtb: interrupt-controller@17a00000: gic-its@17a40000: False schema does not allow
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index 6d3780a75024..5532bf8af211 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -3907,7 +3907,7 @@ intc: interrupt-controller@17a00000 {
>  			#size-cells = <2>;
>  			ranges;
>  
> -			gic-its@17a40000 {
> +			msi-controller@17a40000 {
>  				compatible = "arm,gic-v3-its";
>  				reg = <0 0x17a40000 0 0x20000>;
>  				msi-controller;
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index 27dcda0d4288..3846f5e0f656 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -1362,14 +1362,11 @@  spi9: spi@a84000 {
 			uart9: serial@a84000 {
 				compatible = "qcom,geni-uart";
 				reg = <0x0 0x00a84000 0x0 0x4000>;
-				reg-names = "se";
 				clocks = <&gcc GCC_QUPV3_WRAP1_S1_CLK>;
 				clock-names = "se";
 				pinctrl-0 = <&qup_uart9_default>;
 				pinctrl-names = "default";
 				interrupts = <GIC_SPI 354 IRQ_TYPE_LEVEL_HIGH>;
-				#address-cells = <1>;
-				#size-cells = <0>;
 				status = "disabled";
 			};