| Message ID | 20230417130522.401605-1-brgl@bgdev.pl |
|---|---|
| State | Superseded |
| Headers | show |
| Series | dt-bindings: phy: qmp-ufs: fix clock and clock-names for sa8775p | expand |
On 17/04/2023 15:05, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > We must set *minItems* to 3, not maxItems as this platform requires > exactly three clocks and maxItems is already set to 3 globally. > > Fixes: e5796a9cdf73 ("dt-bindings: phy: qmp-ufs: describe the UFS PHY for sa8775p") Your change makes the code easier to read (more obvious), so I am okay with the change, but I am not okay with commit msg and Fixes tag. Issue is described inaccurately. There is nothing to fix here, because original code was correct. maxItems:3 in implies minItems:3, thus everything worked as should. Feel free to re-phrase the commit msg and remove the Fixes tag. > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml index 94c0fab065a8..a1897a7606df 100644 --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml @@ -78,9 +78,9 @@ allOf: then: properties: clocks: - maxItems: 3 + minItems: 3 clock-names: - maxItems: 3 + minItems: 3 else: properties: clocks: