From patchwork Wed May 11 08:23:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryan Harkin X-Patchwork-Id: 67489 Delivered-To: patch@linaro.org Received: by 10.140.92.199 with SMTP id b65csp100309qge; Wed, 11 May 2016 01:24:13 -0700 (PDT) X-Received: by 10.66.65.169 with SMTP id y9mr2907681pas.102.1462955053477; Wed, 11 May 2016 01:24:13 -0700 (PDT) Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id 15si1490682pfl.18.2016.05.11.01.24.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 May 2016 01:24:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 127DE1A1F68; Wed, 11 May 2016 01:24:13 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received: from mail-wm0-x22e.google.com (mail-wm0-x22e.google.com [IPv6:2a00:1450:400c:c09::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 583EC1A1EC4 for ; Wed, 11 May 2016 01:24:11 -0700 (PDT) Received: by mail-wm0-x22e.google.com with SMTP id e201so208181804wme.0 for ; Wed, 11 May 2016 01:24:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hMIV1OYvy0trcsaraExjfWRm41yH3OTGMbuRBGidg9w=; b=dx1dGSBynuTvKcdv9xloBSD/6qRNhkLkv7gefush4rbnEH2PA4pkQBeOHomcdHzoB3 aUiim3VirFpwuLqp6uZpD8ppEMi6nQ88gxvq3U/znzj/bflbOYMbHbxBgTHURMrDdA/E Q0wNWtTZ9S8U1bHqHKmK7pNkWly0vu57cYOQM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hMIV1OYvy0trcsaraExjfWRm41yH3OTGMbuRBGidg9w=; b=RjnSbBfbYIzOBxbSyIgz/GJDhzq1tn/4u/3M+cWQWuzJvUhVrWdyl+2bLCey5KaexI XjW4cEXQYPBAYMmgZ8U9xUP1CYgAZTU723+AT1beT8JKXQuAS5tq++1bP4ECSbZi9RJS v+S+gyZzZ6YThfjAo+L38al1fMNLw20CNnjKYhVBlU1Pu1D94x1Nf9fWy0+LKqlRCC1o G7ImUkI409RNQ9Vu4UPDG/Y99yuI7S62JnkUT4+982PdxpDR1qb8gWJ3m3VpBgX7J5ZC KJ+c5KPbyZStRFqPIA4n9l72G52cqzJ2zEMAb/7hUGMOpuyK5F6ZvwXj4J799i3Hm5O+ +6QA== X-Gm-Message-State: AOPr4FX9WU7Cppr7WLgDxrEgrSD4nit3ksK0cL3y44P+HUERDc2E+vKaDmb0FJu3FNJxTqhz X-Received: by 10.194.109.65 with SMTP id hq1mr2194715wjb.45.1462955049714; Wed, 11 May 2016 01:24:09 -0700 (PDT) Received: from localhost.localdomain (82-69-54-187.dsl.in-addr.zen.co.uk. [82.69.54.187]) by smtp.gmail.com with ESMTPSA id kz1sm6702856wjc.46.2016.05.11.01.24.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 11 May 2016 01:24:08 -0700 (PDT) From: Ryan Harkin To: linaro-uefi@lists.linaro.org, Leif Lindholm , edk2-devel@lists.01.org Date: Wed, 11 May 2016 09:23:59 +0100 Message-Id: <1462955040-10447-2-git-send-email-ryan.harkin@linaro.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1462955040-10447-1-git-send-email-ryan.harkin@linaro.org> References: <1462955040-10447-1-git-send-email-ryan.harkin@linaro.org> Subject: [edk2] [PATCH 1/2] EmbeddedPkg/Lan9118Dxe: PcdLan9118NegotiationFeatureMask X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ryan Harkin , sudeep.holla@arm.com, Ard Biesheuvel MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Add a PCD to allow the platform to mask in/out specific features of the LAN9118 device advertised during auto-negotiation. For example, the Juno ARM Development Platform doesn't support full duplex mode. This PCD will allow the platform developer to prevent the full duplex modes from being advertised. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ryan Harkin --- EmbeddedPkg/EmbeddedPkg.dec | 1 + EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.inf | 1 + EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.c | 1 + 3 files changed, 3 insertions(+) -- 2.1.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/EmbeddedPkg/EmbeddedPkg.dec b/EmbeddedPkg/EmbeddedPkg.dec index 7bcb133..73f7ee6 100644 --- a/EmbeddedPkg/EmbeddedPkg.dec +++ b/EmbeddedPkg/EmbeddedPkg.dec @@ -147,6 +147,7 @@ [PcdsFixedAtBuild.common] gEmbeddedTokenSpaceGuid.PcdLan9118DxeBaseAddress|0x0|UINT32|0x00000025 gEmbeddedTokenSpaceGuid.PcdLan9118DefaultMacAddress|0x0|UINT64|0x00000026 gEmbeddedTokenSpaceGuid.PcdLan9118DefaultNegotiationTimeout|4000|UINT32|0x00000027 + gEmbeddedTokenSpaceGuid.PcdLan9118NegotiationFeatureMask|0xFFFFFFFF|UINT32|0x00000028 # # Android FastBoot diff --git a/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.inf b/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.inf index 3c2246f..055a055 100644 --- a/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.inf +++ b/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.inf @@ -52,6 +52,7 @@ [FixedPcd] gEmbeddedTokenSpaceGuid.PcdLan9118DxeBaseAddress gEmbeddedTokenSpaceGuid.PcdLan9118DefaultMacAddress gEmbeddedTokenSpaceGuid.PcdLan9118DefaultNegotiationTimeout + gEmbeddedTokenSpaceGuid.PcdLan9118NegotiationFeatureMask [Depex] TRUE diff --git a/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.c b/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.c index 8491396..5ce658c 100644 --- a/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.c +++ b/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.c @@ -648,6 +648,7 @@ AutoNegotiate ( Features &= ~(PHYANA_PAUSE_OP_MASK); Features |= 3 << 10; } + Features &= FixedPcdGet32 (PcdLan9118NegotiationFeatureMask); // Write the features IndirectPHYWrite32 (PHY_INDEX_AUTO_NEG_ADVERT, Features);