[04/10] ARM: uniphier: switch over to USB DM

Message ID 1462962515-13181-5-git-send-email-yamada.masahiro@socionext.com
State New
Headers show

Commit Message

Masahiro Yamada May 11, 2016, 10:28 a.m.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

---

 arch/arm/Kconfig           | 1 +
 include/configs/uniphier.h | 4 ++++
 2 files changed, 5 insertions(+)

-- 
1.9.1

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Comments

Masahiro Yamada May 16, 2016, 1:03 p.m. | #1
Hi Marek,

2016-05-11 20:26 GMT+09:00 Marek Vasut <marex@denx.de>:
> On 05/11/2016 12:28 PM, Masahiro Yamada wrote:

>

> Please, do write commit messages.

>

>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

>> ---

>>

>>  arch/arm/Kconfig           | 1 +

>>  include/configs/uniphier.h | 4 ++++

>>  2 files changed, 5 insertions(+)

>>

>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig

>> index 6b65d8e..59410cb 100644

>> --- a/arch/arm/Kconfig

>> +++ b/arch/arm/Kconfig

>> @@ -723,6 +723,7 @@ config ARCH_UNIPHIER

>>       select DM_SERIAL

>>       select DM_I2C

>>       select DM_MMC

>> +     select DM_USB

>>       help

>>         Support for UniPhier SoC family developed by Socionext Inc.

>>         (formerly, System LSI Business Division of Panasonic Corporation)

>> diff --git a/include/configs/uniphier.h b/include/configs/uniphier.h

>> index 18cb963..868f001 100644

>> --- a/include/configs/uniphier.h

>> +++ b/include/configs/uniphier.h

>> @@ -136,6 +136,10 @@

>>  #define CONFIG_FAT_WRITE

>>  #define CONFIG_DOS_PARTITION

>>

>> +#ifdef CONFIG_USB_DWC3_UNIPHIER

>> +#define CONFIG_USB_XHCI_DWC3

>

> Could this be converted to Kconfig ?

>


I noticed this task was not so easy as I had imagined first.

Before moving CONFIB_USB_XHCI_DWC3,
I need to move CONFIG_USB_XHCI(_HCD)
because USB_XHCI_DWC3 depends on USB_XHCI_HCD.

Before moving CONFIB_USB_XHCI(_HCD),
I need to move CONFIG_USB
because USB_XHCI(_HCD) depends on USB.

A problem here is that many boards
define CONFIG_USB_XHCI without CONFIG_USB.

In spite of that fact, finally I managed to
convert them and pass buildman test.
So, v2 is out now.



-- 
Best Regards
Masahiro Yamada
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Patch

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 6b65d8e..59410cb 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -723,6 +723,7 @@  config ARCH_UNIPHIER
 	select DM_SERIAL
 	select DM_I2C
 	select DM_MMC
+	select DM_USB
 	help
 	  Support for UniPhier SoC family developed by Socionext Inc.
 	  (formerly, System LSI Business Division of Panasonic Corporation)
diff --git a/include/configs/uniphier.h b/include/configs/uniphier.h
index 18cb963..868f001 100644
--- a/include/configs/uniphier.h
+++ b/include/configs/uniphier.h
@@ -136,6 +136,10 @@ 
 #define CONFIG_FAT_WRITE
 #define CONFIG_DOS_PARTITION
 
+#ifdef CONFIG_USB_DWC3_UNIPHIER
+#define CONFIG_USB_XHCI_DWC3
+#endif
+
 /* SD/MMC */
 #define CONFIG_SUPPORT_EMMC_BOOT
 #define CONFIG_GENERIC_MMC