| Message ID | 20230421141006.1005452-6-oswald.buddenhagen@gmx.de |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/7] ALSA: emu10k1: drop redundant snd_emu10k1_efx_playback_hw_free() | expand |
On Fri, 21 Apr 2023 16:10:05 +0200, Oswald Buddenhagen wrote: > > Amends commit 27ae958cf6. I couldn't find this commit ID in the upstream. Also put the commit summary in text, not only the SHA1 ID, too. thanks, Takashi
On Fri, Apr 21, 2023 at 04:54:21PM +0200, Takashi Iwai wrote: >On Fri, 21 Apr 2023 16:10:05 +0200, Oswald Buddenhagen wrote: >> >> Amends commit 27ae958cf6. > >I couldn't find this commit ID in the upstream. > it's from the historic repo. i'll amend it to mention that. >Also put the commit summary in text, not only the SHA1 ID, too. > right.
diff --git a/include/sound/emu10k1.h b/include/sound/emu10k1.h index d1bae032c05f..84ea53e9c83f 100644 --- a/include/sound/emu10k1.h +++ b/include/sound/emu10k1.h @@ -1762,7 +1762,6 @@ struct snd_emu10k1 { struct snd_pcm_substream *pcm_capture_substream; struct snd_pcm_substream *pcm_capture_mic_substream; struct snd_pcm_substream *pcm_capture_efx_substream; - struct snd_pcm_substream *pcm_playback_efx_substream; struct snd_timer *timer; diff --git a/sound/pci/emu10k1/emupcm.c b/sound/pci/emu10k1/emupcm.c index b7830fd5c2b4..c2749ad59e10 100644 --- a/sound/pci/emu10k1/emupcm.c +++ b/sound/pci/emu10k1/emupcm.c @@ -1044,8 +1044,6 @@ static int snd_emu10k1_efx_playback_open(struct snd_pcm_substream *substream) epcm->type = PLAYBACK_EFX; epcm->substream = substream; - emu->pcm_playback_efx_substream = substream; - runtime->private_data = epcm; runtime->private_free = snd_emu10k1_pcm_free_substream; runtime->hw = snd_emu10k1_efx_playback;
Amends commit 27ae958cf6. Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> --- include/sound/emu10k1.h | 1 - sound/pci/emu10k1/emupcm.c | 2 -- 2 files changed, 3 deletions(-)