diff mbox

[Linaro-uefi,03/11] Platforms/AMD/Styx/AmdStyx.dec: remove cross-package includes

Message ID 1462982452-1316-4-git-send-email-ard.biesheuvel@linaro.org
State New
Headers show

Commit Message

Ard Biesheuvel May 11, 2016, 4 p.m. UTC 
Package .DEC files should only describe include directories that belong
to the package, otherwise including one package will pull in headers
from another, obfuscating the dependencies between them.

For instance, as this patch shows, FdtDxe depends on ShellPkg and
MdeModulePkg, so these dependencies should be made explicit rather
than pulling them in via another package.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 Platforms/AMD/Styx/AmdStyx.dec                      | 11 +----------
 Platforms/AMD/Styx/OverdriveBoard/FdtDxe/FdtDxe.inf |  2 ++
 2 files changed, 3 insertions(+), 10 deletions(-)
diff mbox

Patch

diff --git a/Platforms/AMD/Styx/AmdStyx.dec b/Platforms/AMD/Styx/AmdStyx.dec
index a01384f2421c..bba91dda6977 100644
--- a/Platforms/AMD/Styx/AmdStyx.dec
+++ b/Platforms/AMD/Styx/AmdStyx.dec
@@ -20,16 +20,7 @@ 
   PACKAGE_VERSION                = 0.1
 
 [Includes]
-    Common
-    ../../../../AmdModulePkg/Common
-    ../../../../AmdModulePkg/Include
-    ../../../../ArmPkg/Include
-    ../../../../ArmPkg/Library
-    ../../../../EmbeddedPkg/Include
-    ../../../../IntelFrameworkPkg/Include
-    ../../../../MdeModulePkg/Include
-    ../../../../MdePkg/Include
-    ../../../../ShellPkg/Include
+  Common
 
 [LibraryClasses]
 
diff --git a/Platforms/AMD/Styx/OverdriveBoard/FdtDxe/FdtDxe.inf b/Platforms/AMD/Styx/OverdriveBoard/FdtDxe/FdtDxe.inf
index be446a5a5d71..a0b00b3c5dc8 100644
--- a/Platforms/AMD/Styx/OverdriveBoard/FdtDxe/FdtDxe.inf
+++ b/Platforms/AMD/Styx/OverdriveBoard/FdtDxe/FdtDxe.inf
@@ -36,8 +36,10 @@ 
   ArmPkg/ArmPkg.dec
   EmbeddedPkg/EmbeddedPkg.dec
   MdePkg/MdePkg.dec 
+  MdeModulePkg/MdeModulePkg.dec
   AmdModulePkg/AmdModulePkg.dec
   OpenPlatformPkg/Platforms/AMD/Styx/AmdStyx.dec
+  ShellPkg/ShellPkg.dec
     
 [LibraryClasses]
   UefiDriverEntryPoint