diff mbox

[ODP/PATCH] api: sync: remove odp_sync_stores call under octeon.

Message ID 1463151866-29888-1-git-send-email-rizwan.ansari@linaro.org
State Superseded
Headers show

Commit Message

Rizwan Ansari May 13, 2016, 3:04 p.m. UTC
Removes odp_sync_stores() call for OCTEON, Octeon
build will fail, As this api has been already
replaced by odp_mb_full().

Signed-off-by: Rizwan Ansari <rizwan.ansari@linaro.org>
Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com>
---
 platform/linux-generic/odp_ticketlock.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Mike Holmes May 13, 2016, 3:10 p.m. UTC | #1
I think a more usual patch name would be

linux-generic: ticketlock: remove odp_sync_stores for octeon

we try to do approximate area, api, test, docs, linux-generic
implementation, followed by a tighter localisation and then a description,
when I read  "api sync" I assumed it should have gone to api-next

On 13 May 2016 at 11:04, Rizwan Ansari <rizwan.ansari@linaro.org> wrote:

> Removes odp_sync_stores() call for OCTEON, Octeon

> build will fail, As this api has been already

> replaced by odp_mb_full().

>

> Signed-off-by: Rizwan Ansari <rizwan.ansari@linaro.org>

> Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com>

> ---

>  platform/linux-generic/odp_ticketlock.c | 3 ---

>  1 file changed, 3 deletions(-)

>

> diff --git a/platform/linux-generic/odp_ticketlock.c

> b/platform/linux-generic/odp_ticketlock.c

> index 7b4246f..353af9a 100644

> --- a/platform/linux-generic/odp_ticketlock.c

> +++ b/platform/linux-generic/odp_ticketlock.c

> @@ -69,9 +69,6 @@ void odp_ticketlock_unlock(odp_ticketlock_t *ticketlock)

>

>         odp_atomic_store_rel_u32(&ticketlock->cur_ticket, cur + 1);

>

> -#if defined __OCTEON__

> -       odp_sync_stores(); /* SYNCW to flush write buffer */

> -#endif

>  }

>

>  int odp_ticketlock_is_locked(odp_ticketlock_t *ticketlock)

> --

> 2.5.5

>

> _______________________________________________

> lng-odp mailing list

> lng-odp@lists.linaro.org

> https://lists.linaro.org/mailman/listinfo/lng-odp

>




-- 
Mike Holmes
Technical Manager - Linaro Networking Group
Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
"Work should be fun and collaborative, the rest follows"
diff mbox

Patch

diff --git a/platform/linux-generic/odp_ticketlock.c b/platform/linux-generic/odp_ticketlock.c
index 7b4246f..353af9a 100644
--- a/platform/linux-generic/odp_ticketlock.c
+++ b/platform/linux-generic/odp_ticketlock.c
@@ -69,9 +69,6 @@  void odp_ticketlock_unlock(odp_ticketlock_t *ticketlock)
 
 	odp_atomic_store_rel_u32(&ticketlock->cur_ticket, cur + 1);
 
-#if defined __OCTEON__
-	odp_sync_stores(); /* SYNCW to flush write buffer */
-#endif
 }
 
 int odp_ticketlock_is_locked(odp_ticketlock_t *ticketlock)