| Message ID | 20230505205416.55002-2-sakari.ailus@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | ec178312b81448b30947b2cb66b849e4bf43d941 |
| Headers | show |
| Series | Small MC + CIO2 cleanups | expand |
Hi Sakari, Thank you for the patch. On Fri, May 05, 2023 at 11:54:15PM +0300, Sakari Ailus wrote: > fwnode_graph_parse_endpoint() fwnode argument is now const, therefore make > media_entity_get_fwnode_pad() fwnode argument const as well. "now", since 2017 :-) I'd phrase the commit message as The media_entity_get_fwnode_pad() function never modifies its fwnode argument. Make it const to allow usage of the function in contexts where the fwnode pointer is const. > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > drivers/media/mc/mc-entity.c | 2 +- > include/media/media-entity.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c > index c1bc48c4d239..5ea9d3e5d59b 100644 > --- a/drivers/media/mc/mc-entity.c > +++ b/drivers/media/mc/mc-entity.c > @@ -1426,7 +1426,7 @@ struct media_pad *media_pad_remote_pad_unique(const struct media_pad *pad) > EXPORT_SYMBOL_GPL(media_pad_remote_pad_unique); > > int media_entity_get_fwnode_pad(struct media_entity *entity, > - struct fwnode_handle *fwnode, > + const struct fwnode_handle *fwnode, > unsigned long direction_flags) > { > struct fwnode_endpoint endpoint; > diff --git a/include/media/media-entity.h b/include/media/media-entity.h > index e4f556911c3f..2b6cd343ee9e 100644 > --- a/include/media/media-entity.h > +++ b/include/media/media-entity.h > @@ -1079,7 +1079,7 @@ struct media_pipeline *media_pad_pipeline(struct media_pad *pad); > * Return: returns the pad number on success or a negative error code. > */ > int media_entity_get_fwnode_pad(struct media_entity *entity, > - struct fwnode_handle *fwnode, > + const struct fwnode_handle *fwnode, > unsigned long direction_flags); > > /**
diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c index c1bc48c4d239..5ea9d3e5d59b 100644 --- a/drivers/media/mc/mc-entity.c +++ b/drivers/media/mc/mc-entity.c @@ -1426,7 +1426,7 @@ struct media_pad *media_pad_remote_pad_unique(const struct media_pad *pad) EXPORT_SYMBOL_GPL(media_pad_remote_pad_unique); int media_entity_get_fwnode_pad(struct media_entity *entity, - struct fwnode_handle *fwnode, + const struct fwnode_handle *fwnode, unsigned long direction_flags) { struct fwnode_endpoint endpoint; diff --git a/include/media/media-entity.h b/include/media/media-entity.h index e4f556911c3f..2b6cd343ee9e 100644 --- a/include/media/media-entity.h +++ b/include/media/media-entity.h @@ -1079,7 +1079,7 @@ struct media_pipeline *media_pad_pipeline(struct media_pad *pad); * Return: returns the pad number on success or a negative error code. */ int media_entity_get_fwnode_pad(struct media_entity *entity, - struct fwnode_handle *fwnode, + const struct fwnode_handle *fwnode, unsigned long direction_flags); /**
fwnode_graph_parse_endpoint() fwnode argument is now const, therefore make media_entity_get_fwnode_pad() fwnode argument const as well. Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- drivers/media/mc/mc-entity.c | 2 +- include/media/media-entity.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)