diff mbox

[PATCHv9,34/35] linux-generic: test: ringtest: adding helper cmd line parsing

Message ID 1463761851-37121-35-git-send-email-christophe.milard@linaro.org
State Accepted
Commit 9c33d64e92d3fe6e63fe027e8c70eb15b9994f7a
Headers show

Commit Message

Christophe Milard May 20, 2016, 4:30 p.m. UTC
ringtests.c now calls the helper command line parsing so that helper
can collect its options. Hence enabling process mode run.

Signed-off-by: Christophe Milard <christophe.milard@linaro.org>
---
 platform/linux-generic/test/ring/ringtest.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Maxim Uvarov May 20, 2016, 7:08 p.m. UTC | #1
looks like this patch introduced ring infinite loop.

Maxim.

On 05/20/16 19:30, Christophe Milard wrote:
> ringtests.c now calls the helper command line parsing so that helper
> can collect its options. Hence enabling process mode run.
>
> Signed-off-by: Christophe Milard <christophe.milard@linaro.org>
> ---
>   platform/linux-generic/test/ring/ringtest.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/platform/linux-generic/test/ring/ringtest.c b/platform/linux-generic/test/ring/ringtest.c
> index a613fe7..2ebef8a 100644
> --- a/platform/linux-generic/test/ring/ringtest.c
> +++ b/platform/linux-generic/test/ring/ringtest.c
> @@ -417,7 +417,7 @@ static int test_ring(void *arg)
>   	return 0;
>   }
>   
> -int main(int argc TEST_UNUSED, char *argv[] TEST_UNUSED)
> +int main(int argc, char *argv[])
>   {
>   	ring_arg_t rarg;
>   	odph_odpthread_t thread_tbl[MAX_WORKERS];
> @@ -436,6 +436,9 @@ int main(int argc TEST_UNUSED, char *argv[] TEST_UNUSED)
>   		exit(EXIT_FAILURE);
>   	}
>   
> +	/* let helper collect its own arguments (e.g. --odph_proc) */
> +	odph_parse_options(argc, argv, NULL, NULL);
> +
>   	_ring_tailq_init();
>   
>   	odp_cpumask_default_worker(&cpu_mask, MAX_WORKERS);
diff mbox

Patch

diff --git a/platform/linux-generic/test/ring/ringtest.c b/platform/linux-generic/test/ring/ringtest.c
index a613fe7..2ebef8a 100644
--- a/platform/linux-generic/test/ring/ringtest.c
+++ b/platform/linux-generic/test/ring/ringtest.c
@@ -417,7 +417,7 @@  static int test_ring(void *arg)
 	return 0;
 }
 
-int main(int argc TEST_UNUSED, char *argv[] TEST_UNUSED)
+int main(int argc, char *argv[])
 {
 	ring_arg_t rarg;
 	odph_odpthread_t thread_tbl[MAX_WORKERS];
@@ -436,6 +436,9 @@  int main(int argc TEST_UNUSED, char *argv[] TEST_UNUSED)
 		exit(EXIT_FAILURE);
 	}
 
+	/* let helper collect its own arguments (e.g. --odph_proc) */
+	odph_parse_options(argc, argv, NULL, NULL);
+
 	_ring_tailq_init();
 
 	odp_cpumask_default_worker(&cpu_mask, MAX_WORKERS);