| Message ID | 20230516184626.154892-2-afd@ti.com |
|---|---|
| State | Accepted |
| Commit | 06b84c59dff1eeaa786153cb6cf864cc7d6ef176 |
| Headers | show |
| Series | [1/2] clk: keystone: syscon-clk: Allow the clock node to not be of type syscon | expand |
On Wed, May 17, 2023 at 1:53 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On Tue, 16 May 2023 13:46:26 -0500, Andrew Davis wrote: > > This node's register space is not accessed by any other node, which > > is the traditional use for the "syscon" hint. It looks to have been > > added here to make use of a Linux kernel helper syscon_node_to_regmap(). > > The Linux driver now uses a more appropriate helper that does not > > require the hint, so let's remove it from the binding. > > > > Signed-off-by: Andrew Davis <afd@ti.com> > > --- > > .../devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.example.dtb: scm-conf@100000: clock-controller@4140:compatible: ['ti,am654-ehrpwm-tbclk', 'syscon'] is too long > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.example.dtb: clock-controller@4140: compatible: ['ti,am654-ehrpwm-tbclk', 'syscon'] is too long > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml Now failing in linux-next. Rob
On 6/23/23 2:59 PM, Rob Herring wrote: > On Wed, May 17, 2023 at 1:53 AM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On Tue, 16 May 2023 13:46:26 -0500, Andrew Davis wrote: >>> This node's register space is not accessed by any other node, which >>> is the traditional use for the "syscon" hint. It looks to have been >>> added here to make use of a Linux kernel helper syscon_node_to_regmap(). >>> The Linux driver now uses a more appropriate helper that does not >>> require the hint, so let's remove it from the binding. >>> >>> Signed-off-by: Andrew Davis <afd@ti.com> >>> --- >>> .../devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml | 5 ++--- >>> 1 file changed, 2 insertions(+), 3 deletions(-) >>> >> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >> on your patch (DT_CHECKER_FLAGS is new in v5.13): >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.example.dtb: scm-conf@100000: clock-controller@4140:compatible: ['ti,am654-ehrpwm-tbclk', 'syscon'] is too long >> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.example.dtb: clock-controller@4140: compatible: ['ti,am654-ehrpwm-tbclk', 'syscon'] is too long >> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml > > Now failing in linux-next. > Sent fix: https://lore.kernel.org/lkml/20230623201519.194269-1-afd@ti.com/T/#u Andrew
diff --git a/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml b/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml index 66765116aff5..64b8bce5962c 100644 --- a/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml +++ b/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml @@ -16,7 +16,6 @@ properties: - ti,am654-ehrpwm-tbclk - ti,am64-epwm-tbclk - ti,am62-epwm-tbclk - - const: syscon "#clock-cells": const: 1 @@ -33,8 +32,8 @@ additionalProperties: false examples: - | - ehrpwm_tbclk: syscon@4140 { - compatible = "ti,am654-ehrpwm-tbclk", "syscon"; + ehrpwm_tbclk: clock@4140 { + compatible = "ti,am654-ehrpwm-tbclk"; reg = <0x4140 0x18>; #clock-cells = <1>; };
This node's register space is not accessed by any other node, which is the traditional use for the "syscon" hint. It looks to have been added here to make use of a Linux kernel helper syscon_node_to_regmap(). The Linux driver now uses a more appropriate helper that does not require the hint, so let's remove it from the binding. Signed-off-by: Andrew Davis <afd@ti.com> --- .../devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)