diff mbox series

[RESEND] cpupower: Bump soname version

Message ID 20230517191019.643031-1-carnil@debian.org
State New
Headers show
Series [RESEND] cpupower: Bump soname version | expand

Commit Message

Salvatore Bonaccorso May 17, 2023, 7:10 p.m. UTC 
From: Ben Hutchings <ben@decadent.org.uk>

Several functions in the libcpupower API are renamed or removed in
Linux 4.7.  This is an backward-incompatible ABI change, so the
library soname should change from libcpupower.so.0 to
libcpupower.so.1.

Fixes: ac5a181d065d ("cpupower: Add cpuidle parts into library")
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
---
 tools/power/cpupower/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Shuah Khan May 17, 2023, 10:55 p.m. UTC | #1 
On 5/17/23 13:10, Salvatore Bonaccorso wrote:
> From: Ben Hutchings <ben@decadent.org.uk>
> 
> Several functions in the libcpupower API are renamed or removed in
> Linux 4.7.  This is an backward-incompatible ABI change, so the
> library soname should change from libcpupower.so.0 to
> libcpupower.so.1.
> 
> Fixes: ac5a181d065d ("cpupower: Add cpuidle parts into library")
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
> ---

Thank you Salvatore. I will apply this for the next 6.4-rc

thanks,
-- Shuah
Shuah Khan June 5, 2023, 8:13 p.m. UTC | #2 
On 5/17/23 16:55, Shuah Khan wrote:
> On 5/17/23 13:10, Salvatore Bonaccorso wrote:
>> From: Ben Hutchings <ben@decadent.org.uk>
>>
>> Several functions in the libcpupower API are renamed or removed in
>> Linux 4.7.  This is an backward-incompatible ABI change, so the
>> library soname should change from libcpupower.so.0 to
>> libcpupower.so.1.
>>
>> Fixes: ac5a181d065d ("cpupower: Add cpuidle parts into library")
>> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
>> Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
>> ---
> 
> Thank you Salvatore. I will apply this for the next 6.4-rc
> 

I was just about to send this in pull request and did a final
test. I am not really seeing any change in library name.

Does LIB_MAJ need bumping up instead of LIB_MIN?

Can you send me before and after build results?

thanks,
-- Shuah
diff mbox series

Patch

diff --git a/tools/power/cpupower/Makefile b/tools/power/cpupower/Makefile
index 59bfa05dec5d..dc531805a570 100644
--- a/tools/power/cpupower/Makefile
+++ b/tools/power/cpupower/Makefile
@@ -53,7 +53,7 @@  DESTDIR ?=
 
 VERSION:=			$(shell ./utils/version-gen.sh)
 LIB_MAJ=			0.0.1
-LIB_MIN=			0
+LIB_MIN=			1
 
 PACKAGE =			cpupower
 PACKAGE_BUGREPORT =		linux-pm@vger.kernel.org