| Message ID | ZGefR4mTHHo1iQ7H@francesco-nb.int.toradex.com |
|---|---|
| State | New |
| Headers | show |
| Series | DT checker RS485 unevaluated property, 8250 OMAP UART | expand |
diff --git a/Documentation/devicetree/bindings/serial/8250_omap.yaml b/Documentation/devicetree/bindings/serial/8250_omap.yaml index eb3488d8f9ee..e634e98aa994 100644 --- a/Documentation/devicetree/bindings/serial/8250_omap.yaml +++ b/Documentation/devicetree/bindings/serial/8250_omap.yaml @@ -70,6 +70,7 @@ properties: dsr-gpios: true rng-gpios: true dcd-gpios: true + rs485-rts-active-low: true rts-gpio: true power-domains: true clock-frequency: true
Hello, while writing a new DT file I stumbled across this warning .../arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-dev.dtb: serial@2810000: Unevaluated properties are not allowed ('rs485-rts-active-high' was unexpected) From schema: .../Documentation/devicetree/bindings/serial/8250_omap.yaml The property is currently used in the OMAP serial driver drivers/tty/serial/omap-serial.c 1511: if (of_property_read_bool(np, "rs485-rts-active-high")) { and a few DT files. I do require it, despite being wrong, because of some legacy reasons [1]. Before commit 767d3467eb60 ("dt-bindings: serial: 8250_omap: drop rs485 properties") this property was allowed. What should I do? - ignore the warning - send a patch to reintroduce `rs485-rts-active-high: true` in 8250_omap.yaml - something else? I would be inclined to send the following patch, do you agree? [1] https://lore.kernel.org/all/ZBItlBhzo+YETcJO@francesco-nb.int.toradex.com/ Francesco