diff mbox series

[v2,07/10] hw/virtio/vhost-vsock: Include missing 'virtio/virtio-bus.h' header

Message ID 20230524093744.88442-8-philmd@linaro.org
State New
Headers show
Series hw/virtio: Build various target-agnostic objects just once | expand

Commit Message

Philippe Mathieu-Daudé May 24, 2023, 9:37 a.m. UTC 
Instead of having "virtio/virtio-bus.h" implicitly included,
explicitly include it, to avoid when rearranging headers:

  hw/virtio/vhost-vsock-common.c: In function ‘vhost_vsock_common_start’:
  hw/virtio/vhost-vsock-common.c:51:5: error: unknown type name ‘VirtioBusClass’; did you mean ‘VirtioDeviceClass’?
     51 |     VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus);
        |     ^~~~~~~~~~~~~~
        |     VirtioDeviceClass
  hw/virtio/vhost-vsock-common.c:51:25: error: implicit declaration of function ‘VIRTIO_BUS_GET_CLASS’; did you mean ‘VIRTIO_DEVICE_CLASS’? [-Werror=implicit-function-declaration]
     51 |     VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus);
        |                         ^~~~~~~~~~~~~~~~~~~~
        |                         VIRTIO_DEVICE_CLASS

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
---
 hw/virtio/vhost-vsock-common.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Alex Bennée May 24, 2023, 3:04 p.m. UTC | #1 
Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> Instead of having "virtio/virtio-bus.h" implicitly included,
> explicitly include it, to avoid when rearranging headers:
>
>   hw/virtio/vhost-vsock-common.c: In function ‘vhost_vsock_common_start’:
>   hw/virtio/vhost-vsock-common.c:51:5: error: unknown type name ‘VirtioBusClass’; did you mean ‘VirtioDeviceClass’?
>      51 |     VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus);
>         |     ^~~~~~~~~~~~~~
>         |     VirtioDeviceClass
>   hw/virtio/vhost-vsock-common.c:51:25: error: implicit declaration of
> function ‘VIRTIO_BUS_GET_CLASS’; did you mean ‘VIRTIO_DEVICE_CLASS’?
> [-Werror=implicit-function-declaration]
>      51 |     VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus);
>         |                         ^~~~~~~~~~~~~~~~~~~~
>         |                         VIRTIO_DEVICE_CLASS
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reviewed-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  hw/virtio/vhost-vsock-common.c | 1 +
>  1 file changed, 1 insertion(+)
Stefano Garzarella May 26, 2023, 12:29 p.m. UTC | #2 
On Wed, May 24, 2023 at 11:37:41AM +0200, Philippe Mathieu-Daudé wrote:
>Instead of having "virtio/virtio-bus.h" implicitly included,
>explicitly include it, to avoid when rearranging headers:
>
>  hw/virtio/vhost-vsock-common.c: In function ‘vhost_vsock_common_start’:
>  hw/virtio/vhost-vsock-common.c:51:5: error: unknown type name ‘VirtioBusClass’; did you mean ‘VirtioDeviceClass’?
>     51 |     VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus);
>        |     ^~~~~~~~~~~~~~
>        |     VirtioDeviceClass
>  hw/virtio/vhost-vsock-common.c:51:25: error: implicit declaration of function ‘VIRTIO_BUS_GET_CLASS’; did you mean ‘VIRTIO_DEVICE_CLASS’? [-Werror=implicit-function-declaration]
>     51 |     VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus);
>        |                         ^~~~~~~~~~~~~~~~~~~~
>        |                         VIRTIO_DEVICE_CLASS
>
>Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>Reviewed-by: Thomas Huth <thuth@redhat.com>
>---
> hw/virtio/vhost-vsock-common.c | 1 +
> 1 file changed, 1 insertion(+)

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
diff mbox series

Patch

diff --git a/hw/virtio/vhost-vsock-common.c b/hw/virtio/vhost-vsock-common.c
index d2b5519d5a..e89af9b329 100644
--- a/hw/virtio/vhost-vsock-common.c
+++ b/hw/virtio/vhost-vsock-common.c
@@ -11,6 +11,7 @@ 
 #include "qemu/osdep.h"
 #include "standard-headers/linux/virtio_vsock.h"
 #include "qapi/error.h"
+#include "hw/virtio/virtio-bus.h"
 #include "hw/virtio/virtio-access.h"
 #include "qemu/error-report.h"
 #include "hw/qdev-properties.h"