| Message ID | 20230525120956.3095317-2-robimarko@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v3,1/5] soc: qcom: socinfo: move SMEM item struct and defines to a header | expand |
On 25.05.2023 14:09, Robert Marko wrote: > SMEM has been GPL licensed from the start, and there is no reason to use > EXPORT_SYMBOL() so switch to the GPL version. > > Signed-off-by: Robert Marko <robimarko@gmail.com> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > drivers/soc/qcom/smem.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c > index 6be7ea93c78c..bc98520c4969 100644 > --- a/drivers/soc/qcom/smem.c > +++ b/drivers/soc/qcom/smem.c > @@ -500,7 +500,7 @@ int qcom_smem_alloc(unsigned host, unsigned item, size_t size) > > return ret; > } > -EXPORT_SYMBOL(qcom_smem_alloc); > +EXPORT_SYMBOL_GPL(qcom_smem_alloc); > > static void *qcom_smem_get_global(struct qcom_smem *smem, > unsigned item, > @@ -674,7 +674,7 @@ void *qcom_smem_get(unsigned host, unsigned item, size_t *size) > return ptr; > > } > -EXPORT_SYMBOL(qcom_smem_get); > +EXPORT_SYMBOL_GPL(qcom_smem_get); > > /** > * qcom_smem_get_free_space() - retrieve amount of free space in a partition > @@ -719,7 +719,7 @@ int qcom_smem_get_free_space(unsigned host) > > return ret; > } > -EXPORT_SYMBOL(qcom_smem_get_free_space); > +EXPORT_SYMBOL_GPL(qcom_smem_get_free_space); > > static bool addr_in_range(void __iomem *base, size_t size, void *addr) > { > @@ -770,7 +770,7 @@ phys_addr_t qcom_smem_virt_to_phys(void *p) > > return 0; > } > -EXPORT_SYMBOL(qcom_smem_virt_to_phys); > +EXPORT_SYMBOL_GPL(qcom_smem_virt_to_phys); > > static int qcom_smem_get_sbl_version(struct qcom_smem *smem) > {
On 5/25/2023 1:21 PM, Trilok Soni wrote: > On 5/25/2023 5:09 AM, Robert Marko wrote: >> SMEM has been GPL licensed from the start, and there is no reason to use >> EXPORT_SYMBOL() so switch to the GPL version. >> >> Signed-off-by: Robert Marko <robimarko@gmail.com> > > Excellent. Thank you. > > Reviewed-by: Trilok Soni <tsoni@quicinc.com> Correction in email ID. I have a separate one for open-source work which makes the email clients happy. Reviewed-by: Trilok Soni <quic_tsoni@quicinc.com> Sorry for the trouble. ---Trilok Soni
diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c index 6be7ea93c78c..bc98520c4969 100644 --- a/drivers/soc/qcom/smem.c +++ b/drivers/soc/qcom/smem.c @@ -500,7 +500,7 @@ int qcom_smem_alloc(unsigned host, unsigned item, size_t size) return ret; } -EXPORT_SYMBOL(qcom_smem_alloc); +EXPORT_SYMBOL_GPL(qcom_smem_alloc); static void *qcom_smem_get_global(struct qcom_smem *smem, unsigned item, @@ -674,7 +674,7 @@ void *qcom_smem_get(unsigned host, unsigned item, size_t *size) return ptr; } -EXPORT_SYMBOL(qcom_smem_get); +EXPORT_SYMBOL_GPL(qcom_smem_get); /** * qcom_smem_get_free_space() - retrieve amount of free space in a partition @@ -719,7 +719,7 @@ int qcom_smem_get_free_space(unsigned host) return ret; } -EXPORT_SYMBOL(qcom_smem_get_free_space); +EXPORT_SYMBOL_GPL(qcom_smem_get_free_space); static bool addr_in_range(void __iomem *base, size_t size, void *addr) { @@ -770,7 +770,7 @@ phys_addr_t qcom_smem_virt_to_phys(void *p) return 0; } -EXPORT_SYMBOL(qcom_smem_virt_to_phys); +EXPORT_SYMBOL_GPL(qcom_smem_virt_to_phys); static int qcom_smem_get_sbl_version(struct qcom_smem *smem) {
SMEM has been GPL licensed from the start, and there is no reason to use EXPORT_SYMBOL() so switch to the GPL version. Signed-off-by: Robert Marko <robimarko@gmail.com> --- drivers/soc/qcom/smem.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)