| Message ID | 20230525091615.2324824-9-sakari.ailus@linux.intel.com |
|---|---|
| State | Superseded |
| Headers | show
Return-Path: <linux-media-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
by smtp.lore.kernel.org (Postfix) with ESMTP id D3A77C77B7A
for <linux-media@archiver.kernel.org>; Thu, 25 May 2023 09:17:15 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S240258AbjEYJRP (ORCPT <rfc822;linux-media@archiver.kernel.org>);
Thu, 25 May 2023 05:17:15 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52326 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S240042AbjEYJRM (ORCPT
<rfc822;linux-media@vger.kernel.org>);
Thu, 25 May 2023 05:17:12 -0400
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09584197
for <linux-media@vger.kernel.org>;
Thu, 25 May 2023 02:17:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1685006231; x=1716542231;
h=from:to:cc:subject:date:message-id:in-reply-to:
references:mime-version:content-transfer-encoding;
bh=UM4hlgPSJR1C3rB2niR9MgkPW58MDKsQ5aFNB18GC1A=;
b=Ow8Lx8goowV4R7xd7JRrtI0zXJNWT6AG2NBxk86lesH53jdT04MuJv2c
h4Jfv/SwbgT06DPeFm9iaxHlPhSJsXcrE4ED26BLa+iaOw26sb+MxPOrQ
lRqnrG1zu3vMHrwziXmxvbjB27Xe5R+Udr9puX6rPCKQbAcMCpeFaQKC6
6juf2If8jFDjBuDZf/7IIcS/CcsOUUuTOzD4LyoJrrLNBo2WPLauttMa2
ZKM1Bwe4BTujAqC4+hWZ6a52rRnKkddzsfEWS8/zqJp0PsvgaHUNXypZB
3nKNYFcZQSjmns33TN1ZNTaP/6PaYO+I9h/1c8OiqHIG1xiZ1TBMAq1xi
Q==;
X-IronPort-AV: E=McAfee;i="6600,9927,10720"; a="333455656"
X-IronPort-AV: E=Sophos;i="6.00,190,1681196400";
d="scan'208";a="333455656"
Received: from orsmga005.jf.intel.com ([10.7.209.41])
by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
25 May 2023 02:17:08 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=McAfee;i="6600,9927,10720"; a="879029097"
X-IronPort-AV: E=Sophos;i="6.00,190,1681196400";
d="scan'208";a="879029097"
Received: from turnipsi.fi.intel.com (HELO kekkonen.fi.intel.com)
([10.237.72.44])
by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
25 May 2023 02:17:01 -0700
Received: from punajuuri.localdomain (punajuuri.localdomain [192.168.240.130])
by kekkonen.fi.intel.com (Postfix) with ESMTP id 37B39122E00;
Thu, 25 May 2023 12:16:49 +0300 (EEST)
Received: from sailus by punajuuri.localdomain with local (Exim 4.94.2)
(envelope-from <sakari.ailus@linux.intel.com>)
id 1q2758-009koq-2I; Thu, 25 May 2023 12:16:26 +0300
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: laurent.pinchart@ideasonboard.com,
Philipp Zabel <p.zabel@pengutronix.de>, hverkuil@xs4all.nl,
Francesco Dolcini <francesco@dolcini.it>,
aishwarya.kothari@toradex.com, Robert Foss <rfoss@kernel.org>,
Todor Tomov <todor.too@gmail.com>,
Hyun Kwon <hyun.kwon@xilinx.com>, bingbu.cao@intel.com,
niklas.soderlund@ragnatech.se,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Benjamin Mugnier <benjamin.mugnier@foss.st.com>,
Sylvain Petinot <sylvain.petinot@foss.st.com>,
Eugen Hristev <eugen.hristev@collabora.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Maxime Ripard <mripard@kernel.org>,
Rui Miguel Silva <rmfrfs@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Dafna Hirschfeld <dafna@fastmail.com>,
Hugues Fruchet <hugues.fruchet@foss.st.com>,
Yong Deng <yong.deng@magewell.com>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
"Lad, Prabhakar" <prabhakar.csengg@gmail.com>,
Benoit Parrot <bparrot@ti.com>,
Steve Longerbeam <slongerbeam@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Sowjanya Komatineni <skomatineni@nvidia.com>,
Marco Felsch <m.felsch@pengutronix.de>
Subject: [RESEND PATCH v3 08/32] media: v4l: async: Don't check whether asd is
NULL in validity check
Date: Thu, 25 May 2023 12:15:51 +0300
Message-Id: <20230525091615.2324824-9-sakari.ailus@linux.intel.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20230525091615.2324824-1-sakari.ailus@linux.intel.com>
References: <20230525091615.2324824-1-sakari.ailus@linux.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk
List-ID: <linux-media.vger.kernel.org>
X-Mailing-List: linux-media@vger.kernel.org
|
| Series |
Separate links and async sub-devices
|
expand
|
diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c index aef9a16e892ef..7c924faac4c10 100644 --- a/drivers/media/v4l2-core/v4l2-async.c +++ b/drivers/media/v4l2-core/v4l2-async.c @@ -552,9 +552,6 @@ static int v4l2_async_nf_asd_valid(struct v4l2_async_notifier *notifier, { struct device *dev = notifier_dev(notifier); - if (!asd) - return -EINVAL; - switch (asd->match_type) { case V4L2_ASYNC_MATCH_I2C: case V4L2_ASYNC_MATCH_FWNODE:
The callers do pass a non-NULL asd to v4l2_async_nf_asd_valid() already. There's no need for the NULL check here. Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- drivers/media/v4l2-core/v4l2-async.c | 3 --- 1 file changed, 3 deletions(-)