diff mbox

[04/10] validation: tm: handle pktio open/config failures properly

Message ID 1464219423-14977-5-git-send-email-bill.fischofer@linaro.org
State Superseded
Headers show

Commit Message

Bill Fischofer May 25, 2016, 11:36 p.m. UTC 
Add proper sequencing of checks for pktio open / configure failures.

Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org>
---
 test/validation/traffic_mngr/traffic_mngr.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
diff mbox

Patch

diff --git a/test/validation/traffic_mngr/traffic_mngr.c b/test/validation/traffic_mngr/traffic_mngr.c
index 2bbcc1d..e099083 100644
--- a/test/validation/traffic_mngr/traffic_mngr.c
+++ b/test/validation/traffic_mngr/traffic_mngr.c
@@ -492,19 +492,19 @@  static int open_pktios(void)
 				       &pktio_param);
 		if (pktio == ODP_PKTIO_INVALID)
 			pktio = odp_pktio_lookup(iface_name[iface]);
+		if (pktio == ODP_PKTIO_INVALID) {
+			LOG_ERR("odp_pktio_open() failed\n");
+			return -1;
+		}
 
 		/* Set defaults for PktIn and PktOut queues */
-		odp_pktin_queue_config(pktio, NULL);
-		odp_pktout_queue_config(pktio, NULL);
+		(void)odp_pktin_queue_config(pktio, NULL);
+		(void)odp_pktout_queue_config(pktio, NULL);
 		rc = odp_pktio_promisc_mode_set(pktio, true);
 		if (rc != 0)
 			printf("****** promisc_mode_set failed  ******\n");
 
 		pktios[iface] = pktio;
-		if (pktio == ODP_PKTIO_INVALID) {
-			LOG_ERR("odp_pktio_open() failed\n");
-			return -1;
-		}
 
 		if (odp_pktin_queue(pktio, &pktins[iface], 1) != 1) {
 			odp_pktio_close(pktio);