| Message ID | 20230613112240.3361-1-tiwai@suse.de |
|---|---|
| State | Accepted |
| Commit | 44e46572f0bae431a6092e3cfd2f47bff8b8d18c |
| Headers | show |
| Series | [v2] regmap: regcache: Don't sync read-only registers | expand |
On Tue, 13 Jun 2023 13:22:40 +0200, Takashi Iwai wrote: > regcache_maple_sync() tries to sync all cached values no matter > whether it's writable or not. OTOH, regache_sync_val() does care the > wrtability and returns -EIO for a read-only register. This results in > an error message like: > snd_hda_codec_realtek hdaudioC0D0: Unable to sync register 0x2f0009. -5 > and the sync loop is aborted incompletely. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git for-next Thanks! [1/1] regmap: regcache: Don't sync read-only registers commit: 44e46572f0bae431a6092e3cfd2f47bff8b8d18c All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c index 029564695dbb..97c681fcf9f6 100644 --- a/drivers/base/regmap/regcache.c +++ b/drivers/base/regmap/regcache.c @@ -284,6 +284,9 @@ static bool regcache_reg_needs_sync(struct regmap *map, unsigned int reg, { int ret; + if (!regmap_writeable(map, reg)) + return false; + /* If we don't know the chip just got reset, then sync everything. */ if (!map->no_sync_defaults) return true;
regcache_maple_sync() tries to sync all cached values no matter whether it's writable or not. OTOH, regache_sync_val() does care the wrtability and returns -EIO for a read-only register. This results in an error message like: snd_hda_codec_realtek hdaudioC0D0: Unable to sync register 0x2f0009. -5 and the sync loop is aborted incompletely. This patch adds the writable register check to regcache_sync_val() for addressing the bug above. Note that, although we may add the check in the caller side (regcache_maple_sync()), here we put in regcache_sync_val(), so that a similar case like this can be avoided in future. Fixes: f033c26de5a5 ("regmap: Add maple tree based register cache") Link: https://lore.kernel.org/r/877cs7g6f1.wl-tiwai@suse.de Signed-off-by: Takashi Iwai <tiwai@suse.de> --- drivers/base/regmap/regcache.c | 3 +++ 1 file changed, 3 insertions(+)