diff mbox series

[v1,1/1] gpio: lpc18xx: Remove unused of_gpio.h inclusion

Message ID 20230615162519.21244-1-andriy.shevchenko@linux.intel.com
State Accepted
Commit 03a5233a8231baf4f717d0349e76d2b1f7d40e2d
Headers show
Series [v1,1/1] gpio: lpc18xx: Remove unused of_gpio.h inclusion | expand

Commit Message

Andy Shevchenko June 15, 2023, 4:25 p.m. UTC
The of_gpio.h is not and shouldn't be used in the GPIO drivers.
Remove it.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpio/gpio-lpc18xx.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Linus Walleij June 15, 2023, 6:56 p.m. UTC | #1
On Thu, Jun 15, 2023 at 6:25 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:

> The of_gpio.h is not and shouldn't be used in the GPIO drivers.
> Remove it.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Vladimir Zapolskiy June 15, 2023, 11:37 p.m. UTC | #2
On 6/15/23 19:25, Andy Shevchenko wrote:
> The of_gpio.h is not and shouldn't be used in the GPIO drivers.
> Remove it.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---

Thank you for the correct change.

Acked-by: Vladimir Zapolskiy <vz@mleia.com>

--
Best wishes,
Vladimir
Bartosz Golaszewski June 19, 2023, 12:45 p.m. UTC | #3
On Thu, Jun 15, 2023 at 6:25 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> The of_gpio.h is not and shouldn't be used in the GPIO drivers.
> Remove it.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/gpio/gpio-lpc18xx.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-lpc18xx.c b/drivers/gpio/gpio-lpc18xx.c
> index d711ae06747e..ed3f653a1dfc 100644
> --- a/drivers/gpio/gpio-lpc18xx.c
> +++ b/drivers/gpio/gpio-lpc18xx.c
> @@ -14,7 +14,6 @@
>  #include <linux/module.h>
>  #include <linux/of.h>
>  #include <linux/of_address.h>
> -#include <linux/of_gpio.h>
>  #include <linux/of_irq.h>
>  #include <linux/pinctrl/consumer.h>
>  #include <linux/platform_device.h>
> --
> 2.40.0.1.gaa8946217a0b
>

Applied, thanks!

Bart
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-lpc18xx.c b/drivers/gpio/gpio-lpc18xx.c
index d711ae06747e..ed3f653a1dfc 100644
--- a/drivers/gpio/gpio-lpc18xx.c
+++ b/drivers/gpio/gpio-lpc18xx.c
@@ -14,7 +14,6 @@ 
 #include <linux/module.h>
 #include <linux/of.h>
 #include <linux/of_address.h>
-#include <linux/of_gpio.h>
 #include <linux/of_irq.h>
 #include <linux/pinctrl/consumer.h>
 #include <linux/platform_device.h>