diff mbox series

[V2,7/7] dt-bindings: timer: convert bcm2835-system-timer bindings to YAML

Message ID 20230617133620.53129-8-stefan.wahren@i2se.com
State New
Headers show
Series ARM: dts: bcm283x: Improve device-trees and bindings | expand

Commit Message

Stefan Wahren June 17, 2023, 1:36 p.m. UTC
Convert the DT binding document for bcm2835-system-timer from .txt
to YAML.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
 .../timer/brcm,bcm2835-system-timer.txt       | 22 ---------
 .../timer/brcm,bcm2835-system-timer.yaml      | 48 +++++++++++++++++++
 2 files changed, 48 insertions(+), 22 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
 create mode 100644 Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.yaml

Comments

Daniel Lezcano June 19, 2023, 5 p.m. UTC | #1
On 17/06/2023 15:36, Stefan Wahren wrote:
> Convert the DT binding document for bcm2835-system-timer from .txt
> to YAML.
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
>   .../timer/brcm,bcm2835-system-timer.txt       | 22 ---------
>   .../timer/brcm,bcm2835-system-timer.yaml      | 48 +++++++++++++++++++
>   2 files changed, 48 insertions(+), 22 deletions(-)
>   delete mode 100644 Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
>   create mode 100644 Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.yaml
> 
> diff --git a/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt b/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
> deleted file mode 100644
> index 844bd5fbd04c..000000000000
> --- a/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt

Appliedp patch #7

Thanks
Stefan Wahren June 19, 2023, 6:57 p.m. UTC | #2
Hi Daniel,

Am 19.06.23 um 19:00 schrieb Daniel Lezcano:
> On 17/06/2023 15:36, Stefan Wahren wrote:
>> Convert the DT binding document for bcm2835-system-timer from .txt
>> to YAML.
>>
>> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> ---
>>   .../timer/brcm,bcm2835-system-timer.txt       | 22 ---------
>>   .../timer/brcm,bcm2835-system-timer.yaml      | 48 +++++++++++++++++++
>>   2 files changed, 48 insertions(+), 22 deletions(-)
>>   delete mode 100644 
>> Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
>>   create mode 100644 
>> Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.yaml
>>
>> diff --git 
>> a/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt b/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
>> deleted file mode 100644
>> index 844bd5fbd04c..000000000000
>> --- 
>> a/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
> 
> Appliedp patch #7

i'm so sorry but i accidentially added a Reviewed-by from Rob, which is 
wrong here. I should have added to the patch 6 :-(

Regards Stefan

> 
> Thanks
>
Daniel Lezcano June 19, 2023, 8 p.m. UTC | #3
On 19/06/2023 20:57, Stefan Wahren wrote:
> Hi Daniel,
> 
> Am 19.06.23 um 19:00 schrieb Daniel Lezcano:
>> On 17/06/2023 15:36, Stefan Wahren wrote:
>>> Convert the DT binding document for bcm2835-system-timer from .txt
>>> to YAML.
>>>
>>> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
>>> Reviewed-by: Rob Herring <robh@kernel.org>
>>> ---
>>>   .../timer/brcm,bcm2835-system-timer.txt       | 22 ---------
>>>   .../timer/brcm,bcm2835-system-timer.yaml      | 48 +++++++++++++++++++
>>>   2 files changed, 48 insertions(+), 22 deletions(-)
>>>   delete mode 100644 
>>> Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
>>>   create mode 100644 
>>> Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.yaml
>>>
>>> diff --git 
>>> a/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt b/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
>>> deleted file mode 100644
>>> index 844bd5fbd04c..000000000000
>>> --- 
>>> a/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
>>
>> Appliedp patch #7
> 
> i'm so sorry but i accidentially added a Reviewed-by from Rob, which is 
> wrong here. I should have added to the patch 6 :-(

No worries, I'll drop the patch and wait for its Acked-by
Stefan Wahren June 26, 2023, 6:16 p.m. UTC | #4
Hi Rob,

Am 19.06.23 um 20:57 schrieb Stefan Wahren:
> Hi Daniel,
> 
> Am 19.06.23 um 19:00 schrieb Daniel Lezcano:
>> On 17/06/2023 15:36, Stefan Wahren wrote:
>>> Convert the DT binding document for bcm2835-system-timer from .txt
>>> to YAML.
>>>
>>> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
>>> Reviewed-by: Rob Herring <robh@kernel.org>
>>> ---
>>>   .../timer/brcm,bcm2835-system-timer.txt       | 22 ---------
>>>   .../timer/brcm,bcm2835-system-timer.yaml      | 48 +++++++++++++++++++
>>>   2 files changed, 48 insertions(+), 22 deletions(-)
>>>   delete mode 100644 
>>> Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
>>>   create mode 100644 
>>> Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.yaml
>>>
>>> diff --git 
>>> a/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt b/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
>>> deleted file mode 100644
>>> index 844bd5fbd04c..000000000000
>>> --- 
>>> a/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
>>
>> Appliedp patch #7
> 
> i'm so sorry but i accidentially added a Reviewed-by from Rob, which is 
> wrong here. I should have added to the patch 6 :-(

did you noticed the problem about the accidentially wrong added Reviewed-by?

Best regards

> 
> Regards Stefan
> 
>>
>> Thanks
>>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt b/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
deleted file mode 100644
index 844bd5fbd04c..000000000000
--- a/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
+++ /dev/null
@@ -1,22 +0,0 @@ 
-BCM2835 System Timer
-
-The System Timer peripheral provides four 32-bit timer channels and a
-single 64-bit free running counter. Each channel has an output compare
-register, which is compared against the 32 least significant bits of the
-free running counter values, and generates an interrupt.
-
-Required properties:
-
-- compatible : should be "brcm,bcm2835-system-timer"
-- reg : Specifies base physical address and size of the registers.
-- interrupts : A list of 4 interrupt sinks; one per timer channel.
-- clock-frequency : The frequency of the clock that drives the counter, in Hz.
-
-Example:
-
-timer {
-	compatible = "brcm,bcm2835-system-timer";
-	reg = <0x7e003000 0x1000>;
-	interrupts = <1 0>, <1 1>, <1 2>, <1 3>;
-	clock-frequency = <1000000>;
-};
diff --git a/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.yaml b/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.yaml
new file mode 100644
index 000000000000..227b44788a48
--- /dev/null
+++ b/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.yaml
@@ -0,0 +1,48 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/timer/brcm,bcm2835-system-timer.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: BCM2835 System Timer
+
+maintainers:
+  - Stefan Wahren <stefan.wahren@i2se.com>
+
+description:
+  The System Timer peripheral provides four 32-bit timer channels and a
+  single 64-bit free running counter. Each channel has an output compare
+  register, which is compared against the 32 least significant bits of the
+  free running counter values, and generates an interrupt.
+
+properties:
+  compatible:
+    const: brcm,bcm2835-system-timer
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    items:
+      - description: System Timer Compare 0 match (used by VideoCore GPU)
+      - description: System Timer Compare 1 match (usable for ARM core)
+      - description: System Timer Compare 2 match (used by VideoCore GPU)
+      - description: System Timer Compare 3 match (usable for ARM core)
+
+  clock-frequency: true
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+additionalProperties: false
+
+examples:
+  - |
+    timer@7e003000 {
+      compatible = "brcm,bcm2835-system-timer";
+      reg = <0x7e003000 0x1000>;
+      interrupts = <1 0>, <1 1>, <1 2>, <1 3>;
+      clock-frequency = <1000000>;
+    };