| Message ID | 20230619074153.44268-2-philmd@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | exec: Header cleanups around memory.h/address-spaces.h | expand |
On 6/19/23 09:41, Philippe Mathieu-Daudé wrote: > hw/net/i82596.c access the global 'address_space_memory' > calling the ld/st_phys() API. address_space_memory is > declared in "exec/address-spaces.h". Currently this header > is indirectly pulled in via another header. Explicitly include > it to avoid when refactoring unrelated headers: > > hw/net/i82596.c:91:23: error: use of undeclared identifier 'address_space_memory'; did you mean 'address_space_destroy'? > return ldub_phys(&address_space_memory, addr); > ^~~~~~~~~~~~~~~~~~~~ > address_space_destroy > > Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org> > --- > hw/net/i82596.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/hw/net/i82596.c b/hw/net/i82596.c index ec21e2699a..9b9e3aa792 100644 --- a/hw/net/i82596.c +++ b/hw/net/i82596.c @@ -15,6 +15,7 @@ #include "hw/irq.h" #include "hw/qdev-properties.h" #include "migration/vmstate.h" +#include "exec/address-spaces.h" #include "qemu/module.h" #include "trace.h" #include "i82596.h"
hw/net/i82596.c access the global 'address_space_memory' calling the ld/st_phys() API. address_space_memory is declared in "exec/address-spaces.h". Currently this header is indirectly pulled in via another header. Explicitly include it to avoid when refactoring unrelated headers: hw/net/i82596.c:91:23: error: use of undeclared identifier 'address_space_memory'; did you mean 'address_space_destroy'? return ldub_phys(&address_space_memory, addr); ^~~~~~~~~~~~~~~~~~~~ address_space_destroy Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- hw/net/i82596.c | 1 + 1 file changed, 1 insertion(+)